Fixing fraud cost decision function #254
Conversation
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
==========================================
- Coverage 97.32% 97.07% -0.26%
==========================================
Files 95 95
Lines 2731 2731
==========================================
- Hits 2658 2651 -7
- Misses 73 80 +7
Continue to review full report at Codecov.
|
| @@ -46,7 +46,7 @@ def decision_function(self, y_predicted, extra_cols, threshold): | |||
| if not isinstance(y_predicted, pd.Series): | |||
| y_predicted = pd.Series(y_predicted) | |||
|
|
|||
| transformed_probs = (y_predicted * extra_cols[self.amount_col]) | |||
| transformed_probs = (y_predicted.values * extra_cols[self.amount_col]) | |||
There was a problem hiding this comment.
let's add/change a test case that would have caught this
There was a problem hiding this comment.
Updated all tests for Auto(*) so that the raise_error flag is set to True. Unsure if there's a better alternative (that doesn't require us to remember to set this?)
There was a problem hiding this comment.
one thought would be that we could create a global raise_errors setting. perhaps set with an env variable. i like what you did for now though.
| @@ -46,7 +46,7 @@ def decision_function(self, y_predicted, extra_cols, threshold): | |||
| if not isinstance(y_predicted, pd.Series): | |||
| y_predicted = pd.Series(y_predicted) | |||
|
|
|||
| transformed_probs = (y_predicted * extra_cols[self.amount_col]) | |||
| transformed_probs = (y_predicted.values * extra_cols[self.amount_col]) | |||
There was a problem hiding this comment.
one thought would be that we could create a global raise_errors setting. perhaps set with an env variable. i like what you did for now though.
|
@dsherry I caught the bug purely by coincidence when I was trying to figure out why catboost wasn't working on circleci and was clicking around the docs. We probably didn't catch it earlier because |
|
Oh, oops, I missed all of those changes! I must've been looking at a single commit. Cool. I do have more comments but I'll create a discussion ticket for them. |
Closes #252