Rename ComponentGraph's get_parents to get_inputs#2540
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2540 +/- ##
=====================================
Coverage 99.9% 99.9%
=====================================
Files 285 285
Lines 26170 26170
=====================================
Hits 26134 26134
Misses 36 36
Continue to review full report at Codecov.
|
angela97lin
requested review from
christopherbunn,
chukarsten,
dsherry,
freddyaboulton and
jeremyliweishih
| * Enhancements | ||
| * Fixes | ||
| * Changes | ||
| * Renamed ``ComponentGraph``'s ``get_parents`` to ``get_inputs`` :pr:`2540` |
There was a problem hiding this comment.
Let's also add to breaking changes
chukarsten
left a comment
chukarsten
left a comment
There was a problem hiding this comment.
These are too easy, it feels like a trap. Soon there's going to be a 200+ file changed PR, I know it.
ParthivNaresh
left a comment
ParthivNaresh
left a comment
There was a problem hiding this comment.
Looks solid, just a typo I think but otherwise good to go!
evalml/pipelines/component_graph.py
Outdated
|
|
||
| Returns: | ||
| list[str]: List of inputs to use | ||
| list[str]: List of inputs to for the component. |
There was a problem hiding this comment.
Might have accidentally deleted use here?
|
@chukarsten Nonono, these PRs are so that #2490 doesn't have to be a 1000+ line change PR 😭 |
4 participants
Breaking up #2490 into smaller and cleaner PRs :)
This PR renames
ComponentGraph'sget_parentstoget_inputs; I think this is a little more descriptive of what the method does, especially now that we are requiring .x/.y to be explicitly stated.