Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ComponentGraph's get_parents to get_inputs #2540

Merged
merged 6 commits into from
Jul 26, 2021
Merged

Conversation

angela97lin
Copy link
Contributor

Breaking up #2490 into smaller and cleaner PRs :)

This PR renames ComponentGraph's get_parents to get_inputs; I think this is a little more descriptive of what the method does, especially now that we are requiring .x/.y to be explicitly stated.

@angela97lin angela97lin self-assigned this Jul 22, 2021
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #2540 (8d8e2b4) into main (5ce56b8) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2540   +/-   ##
=====================================
  Coverage   99.9%   99.9%           
=====================================
  Files        285     285           
  Lines      26170   26170           
=====================================
  Hits       26134   26134           
  Misses        36      36           
Impacted Files Coverage Δ
evalml/pipelines/component_graph.py 99.4% <100.0%> (ø)
...valml/tests/pipeline_tests/test_component_graph.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ce56b8...8d8e2b4. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review July 23, 2021 16:25
@angela97lin angela97lin requested a review from a team July 23, 2021 16:25
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -4,6 +4,7 @@ Release Notes
* Enhancements
* Fixes
* Changes
* Renamed ``ComponentGraph``'s ``get_parents`` to ``get_inputs`` :pr:`2540`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add to breaking changes

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are too easy, it feels like a trap. Soon there's going to be a 200+ file changed PR, I know it.

Copy link
Contributor

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid, just a typo I think but otherwise good to go!


Returns:
list[str]: List of inputs to use
list[str]: List of inputs to for the component.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might have accidentally deleted use here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, ty :P

@angela97lin
Copy link
Contributor Author

@chukarsten Nonono, these PRs are so that #2490 doesn't have to be a 1000+ line change PR 😭

@angela97lin angela97lin merged commit 10a8047 into main Jul 26, 2021
@angela97lin angela97lin deleted the rename_get_parents branch July 26, 2021 16:57
@chukarsten chukarsten mentioned this pull request Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants