Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gini coefficient as an objective #2544

Merged
merged 6 commits into from Jul 27, 2021
Merged

Add gini coefficient as an objective #2544

merged 6 commits into from Jul 27, 2021

Conversation

eccabay
Copy link
Contributor

@eccabay eccabay commented Jul 23, 2021

Closes #2102

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #2544 (6202fbf) into main (23f5d9b) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2544     +/-   ##
=======================================
+ Coverage   99.9%   99.9%   +0.1%     
=======================================
  Files        285     285             
  Lines      26203   26212      +9     
=======================================
+ Hits       26167   26176      +9     
  Misses        36      36             
Impacted Files Coverage Δ
evalml/objectives/__init__.py 100.0% <ø> (ø)
evalml/tests/automl_tests/test_automl.py 99.8% <ø> (ø)
evalml/objectives/standard_metrics.py 100.0% <100.0%> (ø)
evalml/tests/objective_tests/test_objectives.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f5d9b...6202fbf. Read the comment docs.

@eccabay eccabay marked this pull request as ready for review July 26, 2021 16:57
@eccabay eccabay requested a review from a team July 26, 2021 16:57
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eccabay Thanks for the write-up on the original issue! I agree with the conclusion/implementation proposed there!

@@ -99,7 +99,7 @@ def test_can_get_only_core_and_all_objective_names():

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gini coefficient is also being tested in test_objective_outputs so I think it's in line with how we test our other objectives.

@angela97lin angela97lin self-requested a review July 27, 2021 16:04
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean and simple, LGTM! 😁

@eccabay eccabay merged commit 3a803e0 into main Jul 27, 2021
@eccabay eccabay deleted the 2102_gini_coef branch July 27, 2021 17:17
@chukarsten chukarsten mentioned this pull request Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Gini coefficient as an objective
3 participants