Move get_hyperparameter_ranges to PipelineBase class from automl/utils module - #2546
Merged
Conversation
…valml into move_get_hyperparameter_ranges
Codecov Report
@@ Coverage Diff @@
## main #2546 +/- ##
=======================================
- Coverage 99.9% 99.9% -0.0%
=======================================
Files 285 285
Lines 26170 26167 -3
=======================================
- Hits 26134 26131 -3
Misses 36 36
Continue to review full report at Codecov.
|
angela97lin
commented
Jul 23, 2021
| evalml.pipelines.PipelineBase | ||
| evalml.pipelines.ClassificationPipeline | ||
| evalml.pipelines.BinaryClassificationPipeline | ||
| evalml.pipelines.classification_pipeline.ClassificationPipeline |
Contributor
Author
angela97lin
marked this pull request as ready for review
July 23, 2021 20:15
angela97lin
requested review from
ParthivNaresh,
chukarsten,
dsherry,
freddyaboulton and
jeremyliweishih
July 23, 2021 20:15
freddyaboulton
approved these changes
Jul 23, 2021
freddyaboulton
left a comment
freddyaboulton
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me @angela97lin !
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More breaking up #2490 into smaller and cleaner PRs :)
This PR moves
get_hyperparameter_rangesfrom automl/utils to a method inPipelineBase. The method was only called in AutoMLAlgorithm, and was passed the pipeline's component graph anyway, so this isn't a big lift. Main reason for this was because it calledComponentGraph's linearized_component_graph method, which I'm thinking about removing since it's only used in a list definition of the component graph.