-
Notifications
You must be signed in to change notification settings - Fork 91
Move get_hyperparameter_ranges
to PipelineBase
class from automl/utils module
#2546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…valml into move_get_hyperparameter_ranges
Codecov Report
@@ Coverage Diff @@
## main #2546 +/- ##
=======================================
- Coverage 99.9% 99.9% -0.0%
=======================================
Files 285 285
Lines 26170 26167 -3
=======================================
- Hits 26134 26131 -3
Misses 36 36
Continue to review full report at Codecov.
|
@@ -95,8 +95,8 @@ Pipeline Base Classes | |||
.. autoapisummary:: | |||
|
|||
evalml.pipelines.PipelineBase | |||
evalml.pipelines.ClassificationPipeline | |||
evalml.pipelines.BinaryClassificationPipeline | |||
evalml.pipelines.classification_pipeline.ClassificationPipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @angela97lin !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
More breaking up #2490 into smaller and cleaner PRs :)
This PR moves
get_hyperparameter_ranges
from automl/utils to a method inPipelineBase
. The method was only called in AutoMLAlgorithm, and was passed the pipeline's component graph anyway, so this isn't a big lift. Main reason for this was because it calledComponentGraph
's linearized_component_graph method, which I'm thinking about removing since it's only used in a list definition of the component graph.