Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move get_hyperparameter_ranges to PipelineBase class from automl/utils module #2546

Merged
merged 8 commits into from Jul 26, 2021

Conversation

angela97lin
Copy link
Contributor

More breaking up #2490 into smaller and cleaner PRs :)

This PR moves get_hyperparameter_ranges from automl/utils to a method in PipelineBase. The method was only called in AutoMLAlgorithm, and was passed the pipeline's component graph anyway, so this isn't a big lift. Main reason for this was because it called ComponentGraph's linearized_component_graph method, which I'm thinking about removing since it's only used in a list definition of the component graph.

@angela97lin angela97lin self-assigned this Jul 23, 2021
@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #2546 (b7fcf0a) into main (10a8047) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2546     +/-   ##
=======================================
- Coverage   99.9%   99.9%   -0.0%     
=======================================
  Files        285     285             
  Lines      26170   26167      -3     
=======================================
- Hits       26134   26131      -3     
  Misses        36      36             
Impacted Files Coverage Δ
evalml/automl/utils.py 100.0% <ø> (ø)
evalml/tests/automl_tests/test_automl_utils.py 100.0% <ø> (ø)
evalml/automl/automl_algorithm/automl_algorithm.py 100.0% <100.0%> (ø)
evalml/pipelines/pipeline_base.py 99.7% <100.0%> (+0.1%) ⬆️
evalml/tests/pipeline_tests/test_pipelines.py 99.9% <100.0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10a8047...b7fcf0a. Read the comment docs.

@@ -95,8 +95,8 @@ Pipeline Base Classes
.. autoapisummary::

evalml.pipelines.PipelineBase
evalml.pipelines.ClassificationPipeline
evalml.pipelines.BinaryClassificationPipeline
evalml.pipelines.classification_pipeline.ClassificationPipeline
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs break without this update (see here); filed an issue to track this long term as #2548

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @angela97lin !

Copy link
Collaborator

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@angela97lin angela97lin merged commit eb71f97 into main Jul 26, 2021
@angela97lin angela97lin deleted the move_get_hyperparameter_ranges branch July 26, 2021 17:33
@chukarsten chukarsten mentioned this pull request Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants