Test split_data does not shuffle for Time Series#2552
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2552 +/- ##
=======================================
+ Coverage 99.9% 99.9% +0.1%
=======================================
Files 285 285
Lines 26097 26103 +6
=======================================
+ Hits 26063 26069 +6
Misses 34 34
Continue to review full report at Codecov.
|
freddyaboulton
approved these changes
Jul 27, 2021
Contributor
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
Looks good to me @eccabay !
angela97lin
approved these changes
Jul 27, 2021
Contributor
angela97lin
left a comment
angela97lin
left a comment
There was a problem hiding this comment.
Thanks for doing this 😁
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1807