Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SMOTE samplers to SMOTE oversampler #2595

Merged
merged 3 commits into from Aug 6, 2021
Merged

Rename SMOTE samplers to SMOTE oversampler #2595

merged 3 commits into from Aug 6, 2021

Conversation

angela97lin
Copy link
Contributor

Reviving some work in #2210:

  • Rename OverSampler --> Oversampler
  • Add "Over" to all of the SMOTE sampler classes, ex: SMOTESampler --> SMOTEOversampler

@angela97lin angela97lin self-assigned this Aug 4, 2021
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #2595 (e36935a) into main (2b56388) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2595   +/-   ##
=====================================
  Coverage   99.9%   99.9%           
=====================================
  Files        295     295           
  Lines      27063   27063           
=====================================
  Hits       27017   27017           
  Misses        46      46           
Impacted Files Coverage Δ
evalml/pipelines/components/__init__.py 100.0% <ø> (ø)
evalml/pipelines/utils.py 99.2% <ø> (ø)
...alml/pipelines/components/transformers/__init__.py 100.0% <100.0%> (ø)
...lines/components/transformers/samplers/__init__.py 100.0% <100.0%> (ø)
...s/components/transformers/samplers/base_sampler.py 100.0% <100.0%> (ø)
...s/components/transformers/samplers/oversamplers.py 100.0% <100.0%> (ø)
evalml/tests/component_tests/test_components.py 100.0% <100.0%> (ø)
evalml/tests/component_tests/test_oversamplers.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b56388...e36935a. Read the comment docs.

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants