Convert Boolean features to Integer in XGBoost estimators #2602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2602 +/- ##
=======================================
+ Coverage 99.9% 99.9% +0.1%
=======================================
Files 295 295
Lines 27063 27093 +30
=======================================
+ Hits 27017 27047 +30
Misses 46 46
Continue to review full report at Codecov.
|
freddyaboulton
requested review from
dsherry,
angela97lin,
bchen1116,
christopherbunn,
chukarsten,
eccabay,
jeremyliweishih and
ParthivNaresh
and removed request for
dsherry and
angela97lin
freddyaboulton
commented
Aug 6, 2021
|
|
||
|
|
||
| def test_xgboost_predict_all_boolean_columns(): | ||
| X = pd.DataFrame({"a": [True, False, True], "b": [True, False, True]}) |
There was a problem hiding this comment.
This is the rare case where black preferred to un-lengthen my original definition 😂
pd.DataFrame({"a": [True, False, True],
"b": [True, False, True]})
jeremyliweishih
approved these changes
Aug 6, 2021
angela97lin
approved these changes
Aug 6, 2021
|
|
||
|
|
||
| def test_xgboost_predict_all_boolean_columns(): | ||
| X = pd.DataFrame({"a": [True, False, True], "b": [True, False, True]}) |
Closed
chukarsten
added a commit
that referenced
this pull request
May 8, 2022
chukarsten
added a commit
that referenced
this pull request
May 9, 2022
chukarsten
added a commit
that referenced
this pull request
May 11, 2022
chukarsten
added a commit
that referenced
this pull request
May 11, 2022
* Reverted #2602 Release notes. * Bumped the minimum version of XGBoost to allow us to handle columns with all booleans to be handled by XGBoost. * Forgot to update xgboost in the conda recipe. * Changed 'py-xgboost' to just xgboost. * Moved the conda version back to 1.5.1 since 1.6.0 wasn't on conda. * Moved the XGBoost minimum to 1.5.1, which should have the fix to revert the bool->int change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #2594. There's a more detailed description in the performance tests but the tl;dr is that it's a bug in xgboost that will be fixed soon. This is a patch to unblock ourselves.
dmlc/xgboost#7157 (comment)
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.