Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove component_graphs as a global variable in test_component_graphs.py #2609

Merged
merged 3 commits into from
Aug 9, 2021

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Aug 9, 2021

Closes #2571. Simple change, just moves component_graph to the parametrize argument.

@angela97lin angela97lin self-assigned this Aug 9, 2021
@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #2609 (7f9e277) into main (7e82a80) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2609     +/-   ##
=======================================
- Coverage   99.9%   99.9%   -0.0%     
=======================================
  Files        295     295             
  Lines      26896   26895      -1     
=======================================
- Hits       26852   26851      -1     
  Misses        44      44             
Impacted Files Coverage Δ
...valml/tests/pipeline_tests/test_component_graph.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e82a80...7f9e277. Read the comment docs.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! good fix 😄

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@angela97lin angela97lin merged commit 06d05ed into main Aug 9, 2021
@angela97lin angela97lin deleted the 2571_refactor_cg_global branch August 9, 2021 22:28
@chukarsten chukarsten mentioned this pull request Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove component_graphs as a global variable in test_component_graphs.py
4 participants