Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add docs build files if ipython 'startup' profile exists #2617

Merged
merged 5 commits into from
Aug 11, 2021

Conversation

dsherry
Copy link
Contributor

@dsherry dsherry commented Aug 10, 2021

Fixes #2567

This will be true on the RTD builder, but false locally. This does mean warnings will show up in the docs for local builds, but I think its better than local docs build simply failing with a path error.

@dsherry dsherry marked this pull request as ready for review August 10, 2021 20:58
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@eccabay eccabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #2617 (fd98a8e) into main (ee9aabd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2617   +/-   ##
=====================================
  Coverage   99.9%   99.9%           
=====================================
  Files        297     297           
  Lines      27027   27027           
=====================================
  Hits       26983   26983           
  Misses        44      44           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee9aabd...fd98a8e. Read the comment docs.

@dsherry dsherry merged commit 716ea92 into main Aug 11, 2021
@chukarsten chukarsten mentioned this pull request Aug 12, 2021
@freddyaboulton freddyaboulton deleted the ds_2567_docs_build branch May 13, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it easy to build docs locally
3 participants