Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add complete command to README and install docs #2627

Merged
merged 7 commits into from
Aug 17, 2021
Merged

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Aug 13, 2021

No description provided.

@gsheni gsheni self-assigned this Aug 13, 2021
@gsheni gsheni changed the title Add complete install command to README and install docs Add complete command to README and install docs Aug 13, 2021
@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #2627 (f208e62) into main (1e056c7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2627   +/-   ##
=====================================
  Coverage   99.9%   99.9%           
=====================================
  Files        297     297           
  Lines      27037   27037           
=====================================
  Hits       26993   26993           
  Misses        44      44           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e056c7...f208e62. Read the comment docs.

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, LGTM! Left just two nit-picky comments, feel free to ignore 😅

README.md Outdated Show resolved Hide resolved
docs/source/install.ipynb Show resolved Hide resolved
@gsheni gsheni marked this pull request as ready for review August 17, 2021 16:44
@gsheni gsheni merged commit 06c21cf into main Aug 17, 2021
@gsheni gsheni deleted the add_complete_install branch August 17, 2021 18:32
@chukarsten chukarsten mentioned this pull request Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants