Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use woodwork outlier detection #2637

Merged
merged 7 commits into from Aug 17, 2021
Merged

Use woodwork outlier detection #2637

merged 7 commits into from Aug 17, 2021

Conversation

bchen1116
Copy link
Contributor

fix #2529

@bchen1116 bchen1116 self-assigned this Aug 16, 2021
@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #2637 (e32a36e) into main (e9260f5) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2637     +/-   ##
=======================================
- Coverage   99.9%   99.9%   -0.0%     
=======================================
  Files        297     297             
  Lines      27067   27037     -30     
=======================================
- Hits       27023   26993     -30     
  Misses        44      44             
Impacted Files Coverage Δ
evalml/data_checks/outliers_data_check.py 100.0% <100.0%> (ø)
...ests/data_checks_tests/test_outliers_data_check.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9260f5...e32a36e. Read the comment docs.

@gsheni gsheni requested a review from tamargrey August 16, 2021 15:39
evalml/data_checks/outliers_data_check.py Outdated Show resolved Hide resolved
evalml/data_checks/outliers_data_check.py Show resolved Hide resolved
evalml/data_checks/outliers_data_check.py Outdated Show resolved Hide resolved
Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, Bryan! This looks good. Its kind of cool that it's relatively simple to swap outlier detection like this!

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like how clean this is now. Great work, LGTM!

@bchen1116 bchen1116 merged commit 1e056c7 into main Aug 17, 2021
@chukarsten chukarsten mentioned this pull request Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update OutlierDataCheck to use Woodwork's implementation of outlier detection
4 participants