Numpy Updates to Tests #2638
Merged
Numpy Updates to Tests #2638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2638 +/- ##
=====================================
Coverage 99.9% 99.9%
=====================================
Files 297 297
Lines 27071 27071
=====================================
Hits 27027 27027
Misses 44 44
Continue to review full report at Codecov.
|
chukarsten
commented
Aug 16, 2021
| plot_data = fig.to_dict()["data"][0] | ||
| assert plot_data["type"] == "bar" | ||
| assert plot_data["x"] == ["0", "1", "2"] | ||
| assert all(plot_data["x"] == ["0", "1", "2"]) |
Contributor
Author
There was a problem hiding this comment.
The original error here comes from the data typing in the dictionary. Before, in plotly <5.1.0, plot_data["x"] was of type list. Now it's an array. Casting it to a list fixes it.
…dated array/list comparison.
…d array/list comparison.
chukarsten
commented
Aug 16, 2021
docs/source/release_notes.rst
Outdated
| * Documentation Changes | ||
| * To avoid local docs build error, only add warning disable and download headers on ReadTheDocs builds, not locally :pr:`2617` | ||
| * Testing Changes | ||
| * Updated partial_dependence tests to change the element-wise comparison per the Numpy upgrade :pr:`2638` |
Contributor
Author
There was a problem hiding this comment.
Pushing a correction to this to say Plotly instead of numpy.
freddyaboulton
approved these changes
Aug 16, 2021
Contributor
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
Thank you @chukarsten !
angela97lin
reviewed
Aug 16, 2021
| @@ -1,5 +1,6 @@ | |||
| docutils>=0.15.2,<0.17 | |||
| pydata-sphinx-theme>=0.3.1 | |||
| astroid<=2.6.6 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tests to support changes to list comparison.