Repository navigation
Remove _put_into_original_order - #2639
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2639 +/- ##
=======================================
- Coverage 99.9% 99.9% -0.0%
=======================================
Files 297 297
Lines 27071 27067 -4
=======================================
- Hits 27027 27023 -4
Misses 44 44
Continue to review full report at Codecov.
|
freddyaboulton
force-pushed
the
2473-remove-put-in-original-order
branch
2 times, most recently
from
August 16, 2021 19:10
f6485e1 to
2d81e55
Compare
freddyaboulton
force-pushed
the
2473-remove-put-in-original-order
branch
from
August 16, 2021 20:30
2d81e55 to
cc8468d
Compare
freddyaboulton
marked this pull request as ready for review
August 16, 2021 21:09
freddyaboulton
requested review from
ParthivNaresh,
angela97lin,
bchen1116,
christopherbunn,
chukarsten,
dsherry,
eccabay and
jeremyliweishih
and removed request for
dsherry
August 16, 2021 21:10
angela97lin
approved these changes
Aug 16, 2021
angela97lin
left a comment
angela97lin
left a comment
Contributor
There was a problem hiding this comment.
Love the cleanup, LGTM!
ParthivNaresh
approved these changes
Aug 17, 2021
| index_and_unknown_columns = _put_into_original_order( | ||
| self.X_train, index_and_unknown_columns | ||
| ) | ||
| index_and_unknown_columns = index_and_unknown_columns |
Contributor
There was a problem hiding this comment.
Why do we need this here?
chukarsten
approved these changes
Aug 17, 2021
chukarsten
left a comment
chukarsten
left a comment
Contributor
There was a problem hiding this comment.
Very nice, thanks for getting this in!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #2473
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.