Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _put_into_original_order #2639

Merged
merged 4 commits into from Aug 17, 2021
Merged

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

Fixes #2473


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #2639 (cc8468d) into main (2b0f42e) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2639     +/-   ##
=======================================
- Coverage   99.9%   99.9%   -0.0%     
=======================================
  Files        297     297             
  Lines      27071   27067      -4     
=======================================
- Hits       27027   27023      -4     
  Misses        44      44             
Impacted Files Coverage Δ
evalml/utils/__init__.py 100.0% <ø> (ø)
evalml/utils/woodwork_utils.py 100.0% <ø> (ø)
evalml/automl/automl_search.py 99.9% <100.0%> (ø)
...components/transformers/encoders/onehot_encoder.py 100.0% <100.0%> (ø)
.../transformers/preprocessing/datetime_featurizer.py 100.0% <100.0%> (ø)
...nts/transformers/preprocessing/text_transformer.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b0f42e...cc8468d. Read the comment docs.

@freddyaboulton freddyaboulton force-pushed the 2473-remove-put-in-original-order branch 2 times, most recently from f6485e1 to 2d81e55 Compare August 16, 2021 19:10
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the cleanup, LGTM!

Copy link
Contributor

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

index_and_unknown_columns = _put_into_original_order(
self.X_train, index_and_unknown_columns
)
index_and_unknown_columns = index_and_unknown_columns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this here?

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks for getting this in!

@freddyaboulton freddyaboulton merged commit e9260f5 into main Aug 17, 2021
@freddyaboulton freddyaboulton deleted the 2473-remove-put-in-original-order branch August 17, 2021 14:05
@chukarsten chukarsten mentioned this pull request Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove _put_in_original_order()
5 participants