Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor time series pipeline code via time series pipeline base class #2649

Merged
merged 13 commits into from Aug 18, 2021

Conversation

angela97lin
Copy link
Contributor

Closes #2614

@angela97lin angela97lin self-assigned this Aug 17, 2021
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #2649 (cedae47) into main (5845df0) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2649     +/-   ##
=======================================
- Coverage   99.9%   99.9%   -0.0%     
=======================================
  Files        297     298      +1     
  Lines      27044   27024     -20     
=======================================
- Hits       27000   26980     -20     
  Misses        44      44             
Impacted Files Coverage Δ
.../pipelines/time_series_classification_pipelines.py 100.0% <100.0%> (ø)
evalml/pipelines/time_series_pipeline_base.py 100.0% <100.0%> (ø)
...valml/pipelines/time_series_regression_pipeline.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5845df0...cedae47. Read the comment docs.

Copy link
Collaborator

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @angela97lin !

class TimeSeriesRegressionPipeline(
RegressionPipeline, metaclass=TimeSeriesPipelineBaseMeta
):
class TimeSeriesRegressionPipeline(TimeSeriesPipelineBase):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please mark that TimeSeriesRegressionPipeline does not inherit from RegressionPipeline as a breaking change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thing 😁

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks GREAT to me!

@angela97lin angela97lin merged commit 0485d7c into main Aug 18, 2021
@angela97lin angela97lin deleted the 2614_refactor_time_series branch August 18, 2021 16:08
@chukarsten chukarsten mentioned this pull request Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor time series pipeline inheritance
4 participants