Refactor time series pipeline code via time series pipeline base class - #2649
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2649 +/- ##
=======================================
- Coverage 99.9% 99.9% -0.0%
=======================================
Files 297 298 +1
Lines 27044 27024 -20
=======================================
- Hits 27000 26980 -20
Misses 44 44
Continue to review full report at Codecov.
|
… into 2614_refactor_time_series
angela97lin
marked this pull request as ready for review
August 17, 2021 21:10
angela97lin
requested review from
ParthivNaresh,
bchen1116,
chukarsten,
dsherry,
eccabay,
freddyaboulton and
jeremyliweishih
August 17, 2021 21:10
freddyaboulton
approved these changes
Aug 18, 2021
freddyaboulton
left a comment
freddyaboulton
left a comment
Contributor
There was a problem hiding this comment.
Thank you @angela97lin !
| class TimeSeriesRegressionPipeline( | ||
| RegressionPipeline, metaclass=TimeSeriesPipelineBaseMeta | ||
| ): | ||
| class TimeSeriesRegressionPipeline(TimeSeriesPipelineBase): |
Contributor
There was a problem hiding this comment.
Can you please mark that TimeSeriesRegressionPipeline does not inherit from RegressionPipeline as a breaking change?
jeremyliweishih
approved these changes
Aug 18, 2021
jeremyliweishih
left a comment
jeremyliweishih
left a comment
Collaborator
There was a problem hiding this comment.
looks GREAT to me!
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2614