Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2653 +/- ##
=======================================
+ Coverage 99.8% 99.8% +0.1%
=======================================
Files 297 302 +5
Lines 27741 28128 +387
=======================================
+ Hits 27664 28050 +386
- Misses 77 78 +1
Continue to review full report at Codecov.
|
9bc885c to
23fe8f9
Compare
christopherbunn
commented
Aug 24, 2021
Comment on lines
+42
to
+48
| n_components = 54 | ||
| elif is_using_windows and not is_running_py_39_or_above: | ||
| # No prophet | ||
| n_components = 53 | ||
| n_components = 55 | ||
| elif is_using_windows and is_running_py_39_or_above: | ||
| # No detrender, no arima, no prophet | ||
| n_components = 51 | ||
| n_components = 53 |
Contributor
Author
There was a problem hiding this comment.
Since these are Windows/Conda tests, we might just not get coverage for this section until we merge to main.
freddyaboulton
previously requested changes
Aug 26, 2021
evalml/pipelines/components/ensemble/stacked_ensemble_regressor.py
Outdated
Show resolved
Hide resolved
eccabay
reviewed
Aug 27, 2021
evalml/pipelines/components/ensemble/stacked_ensemble_classifier.py
Outdated
Show resolved
Hide resolved
evalml/pipelines/components/ensemble/stacked_ensemble_classifier.py
Outdated
Show resolved
Hide resolved
98daa6e to
fad73b5
Compare
eb07d97 to
24a981d
Compare
Contributor
Author
eccabay
approved these changes
Sep 7, 2021
Contributor
eccabay
left a comment
There was a problem hiding this comment.
Nice, this continues to be awesome work! Just left a couple small suggestions and nits.
| # The total number of minimal components is 42 | ||
| # The total number of components is 53 | ||
| # The total number of minimal components is 43 | ||
| # The total number of components is 56 |
Contributor
There was a problem hiding this comment.
Not sure 56 is the correct value?
a7a13b7 to
5068338
Compare
24ee8cf to
5359ef0
Compare
Addressed comments in this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1930