Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete drop_nan_target_rows util method #2737

Merged
merged 5 commits into from Sep 9, 2021
Merged

Conversation

angela97lin
Copy link
Contributor

Closes #2684

@angela97lin angela97lin self-assigned this Sep 1, 2021
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #2737 (aed0ce0) into main (adb844b) will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2737     +/-   ##
=======================================
- Coverage   99.9%   99.9%   -0.0%     
=======================================
  Files        301     300      -1     
  Lines      27751   27705     -46     
=======================================
- Hits       27702   27656     -46     
  Misses        49      49             
Impacted Files Coverage Δ
evalml/preprocessing/__init__.py 100.0% <ø> (ø)
evalml/preprocessing/utils.py 100.0% <ø> (ø)
evalml/tests/utils_tests/test_gen_utils.py 100.0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adb844b...aed0ce0. Read the comment docs.

@jeremyliweishih
Copy link
Contributor

instead of just deleting it, is there any value in changing it into a component?

@angela97lin
Copy link
Contributor Author

instead of just deleting it, is there any value in changing it into a component?

Good question, we have #2705 to track that :) (Not explicitly dropping just NaN targets, but also rows in the features too)

@jeremyliweishih
Copy link
Contributor

@angela97lin sounds good! it might be good to link this PR to that issue if we ever want to repurpose some of the code.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Collaborator

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it and love stories like this.

@angela97lin angela97lin merged commit 84df8af into main Sep 9, 2021
@angela97lin angela97lin deleted the 2684_drop_na_utils branch September 9, 2021 17:30
@chukarsten chukarsten mentioned this pull request Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete drop_nan_target_rows util method
3 participants