Fixing flaky TargetDistributionDataCheck test - #2748
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2748 +/- ##
=====================================
Coverage 99.9% 99.9%
=====================================
Files 301 301
Lines 27819 27819
=====================================
Hits 27770 27770
Misses 49 49
Continue to review full report at Codecov.
|
ParthivNaresh
changed the title
ParthivNaresh
requested review from
bchen1116,
chukarsten and
freddyaboulton
September 7, 2021 13:33
chukarsten
approved these changes
Sep 7, 2021
chukarsten
left a comment
chukarsten
left a comment
Contributor
There was a problem hiding this comment.
Nice, thanks Parthiv!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2581
New test rounds the Shapiro value to the tenths place. Confirmed that the old test ran into a rounding issue once every few thousand runs. This test passed after 30,000 runs so I'm assuming the problem should be fixed.
This fix is fine for now until we can address #2749