Fix ROC/confusion matrix if user passes own objectives #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
==========================================
+ Coverage 96.99% 97.01% +0.01%
==========================================
Files 95 95
Lines 2932 2950 +18
==========================================
+ Hits 2844 2862 +18
Misses 88 88
Continue to review full report at Codecov.
|
kmax12
suggested changes
Dec 26, 2019
evalml/models/auto_base.py
Outdated
| @@ -52,6 +57,18 @@ def __init__(self, problem_type, tuner, cv, objective, max_pipelines, max_time, | |||
| if existing_main_objective is not None: | |||
| additional_objectives.remove(existing_main_objective) | |||
|
|
|||
| # hacky, disallows non-numeric metrics from being primary objective | |||
| if isinstance(self.objective, ConfusionMatrix) or isinstance(self.objective, ROC): | |||
There was a problem hiding this comment.
should this be in auto classifier? i dont think these metrics are valid for regression problems
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #246.
Somewhat hacky / hard-coded though, could be worthwhile to do the refactor necessary for metrics that don't return single numerical values.