Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce estimator in pipeline #277

Merged
merged 6 commits into from
Dec 13, 2019
Merged

Enforce estimator in pipeline #277

merged 6 commits into from
Dec 13, 2019

Conversation

angela97lin
Copy link
Contributor

Closes #229 with temporary fix.

(See #273 for further discussion)

@codecov
Copy link

codecov bot commented Dec 12, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@799f142). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #277   +/-   ##
=========================================
  Coverage          ?   97.04%           
=========================================
  Files             ?       95           
  Lines             ?     2742           
  Branches          ?        0           
=========================================
  Hits              ?     2661           
  Misses            ?       81           
  Partials          ?        0
Impacted Files Coverage Δ
evalml/pipelines/pipeline_base.py 96.62% <100%> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 799f142...8e914a9. Read the comment docs.

@angela97lin angela97lin self-assigned this Dec 12, 2019
jeremyliweishih
jeremyliweishih previously approved these changes Dec 12, 2019
View reviewed changes
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little comment over error raised but otherwise LGTM

evalml/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 13, 2019 •
edited
Loading

Codecov Report

Merging #277 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
- Coverage   97.03%   96.99%   -0.04%     
==========================================
  Files          95       95              
  Lines        2932     2932              
==========================================
- Hits         2845     2844       -1     
- Misses         87       88       +1
Impacted Files Coverage Δ
evalml/pipelines/pipeline_base.py 96.62% <100%> (-0.72%) ⬇️
evalml/tests/pipeline_tests/test_pipelines.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67102c8...eed7561. Read the comment docs.

kmax12
kmax12 previously approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

evalml/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
evalml/pipelines/pipeline_base.py Show resolved Hide resolved
jeremyliweishih
jeremyliweishih approved these changes Dec 13, 2019
View reviewed changes
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit:

@angela97lin angela97lin merged commit e7f1b2c into master Dec 13, 2019
@angela97lin angela97lin deleted the pipeline_estimator branch December 13, 2019 20:35
@angela97lin angela97lin restored the pipeline_estimator branch December 13, 2019 21:38
@angela97lin angela97lin deleted the pipeline_estimator branch December 14, 2019 18:38
@angela97lin angela97lin mentioned this pull request Dec 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyliweishih jeremyliweishih jeremyliweishih approved these changes

@dsherry dsherry Awaiting requested review from dsherry

@kmax12 kmax12 Awaiting requested review from kmax12

Assignees

@angela97lin angela97lin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PipelineBase Errors Without Estimator
3 participants
@angela97lin @kmax12 @jeremyliweishih