Increased container size and fixed Windows CI errors #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
=========================================
Coverage ? 97.03%
=========================================
Files ? 95
Lines ? 2932
Branches ? 0
=========================================
Hits ? 2845
Misses ? 87
Partials ? 0Continue to review full report at Codecov.
|
christopherbunn
changed the title
jeremyliweishih
approved these changes
Dec 13, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finding optimal container size:
Currently set to use linux container with 8 cores. Windows only has one configuration (4 cores) so we'll separate the test call as
make win-circleci.Re: Windows CircleCI errors, it looks like
ipywidgetsisn't set to install in the requirements.txt. I've updated it so the FigureWidget object can work properly.