Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased container size and fixed Windows CI errors #278

Merged
merged 9 commits into from Dec 13, 2019

Conversation

christopherbunn
Copy link
Contributor

@christopherbunn christopherbunn commented Dec 12, 2019

Finding optimal container size:

  • 4 cores
  • Unit test time average: 6m 4.33s
  • 8 cores
  • Unit test time average: 4m 36s

Currently set to use linux container with 8 cores. Windows only has one configuration (4 cores) so we'll separate the test call as make win-circleci.

Re: Windows CircleCI errors, it looks like ipywidgets isn't set to install in the requirements.txt. I've updated it so the FigureWidget object can work properly.

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

No coverage uploaded for pull request base (master@799f142). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #278   +/-   ##
=========================================
  Coverage          ?   97.03%           
=========================================
  Files             ?       95           
  Lines             ?     2932           
  Branches          ?        0           
=========================================
  Hits              ?     2845           
  Misses            ?       87           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 799f142...0fe538f. Read the comment docs.

@christopherbunn christopherbunn changed the title [WIP] Increasing container size Increased container size and fixed Windows CI errors Dec 12, 2019
@christopherbunn christopherbunn merged commit 0529e3c into master Dec 13, 2019
@angela97lin angela97lin mentioned this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants