Revert sktime minimum requirement to 0.7.0 #2811
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2811 +/- ##
=======================================
+ Coverage 99.8% 99.8% +0.1%
=======================================
Files 297 297
Lines 27718 27719 +1
=======================================
+ Hits 27650 27651 +1
Misses 68 68
Continue to review full report at Codecov.
|
freddyaboulton
changed the title
freddyaboulton
changed the title
| on: | ||
| schedule: | ||
| - cron: '0 3 * * *' | ||
| - cron: '0 7 * * *' |
There was a problem hiding this comment.
I was confused as to why the linux nightlies would pass and the windows ones would fail given that a fix was merged in #2808. It's because they ran at different times. I updated this to run at 3 am EST (note the github yaml expects UTC time).
There was a problem hiding this comment.
ah yes, my half-asleep PR was merged in at 1am 😂
| with pytest.raises(ValueError) as exec_info: | ||
| y_shuffled = y.sample(frac=1, replace=False) | ||
| detrender.fit_transform(X, y_shuffled) | ||
| assert "monotonically" in str(exec_info.value) |
freddyaboulton
requested review from
ParthivNaresh,
angela97lin,
bchen1116,
christopherbunn,
chukarsten,
dsherry,
eccabay and
jeremyliweishih
angela97lin
left a comment
angela97lin
left a comment
There was a problem hiding this comment.
thank you! I think this makes much more sense 😂 🙏
Pull Request Description
Change sktime minimum requirement to 0.7.0
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.