Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert sktime minimum requirement to 0.7.0 #2811

Merged
merged 5 commits into from
Sep 20, 2021
Merged

Conversation

freddyaboulton
Copy link
Contributor

@freddyaboulton freddyaboulton commented Sep 20, 2021

Pull Request Description

Change sktime minimum requirement to 0.7.0


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #2811 (40068b2) into main (20733f3) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2811     +/-   ##
=======================================
+ Coverage   99.8%   99.8%   +0.1%     
=======================================
  Files        297     297             
  Lines      27718   27719      +1     
=======================================
+ Hits       27650   27651      +1     
  Misses        68      68             
Impacted Files Coverage Δ
...tests/component_tests/test_polynomial_detrender.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20733f3...40068b2. Read the comment docs.

@freddyaboulton freddyaboulton changed the title Update error message for sktime 0.8.0 Change sktime minimum requirement to 0.7.0 Sep 20, 2021
@freddyaboulton freddyaboulton changed the title Change sktime minimum requirement to 0.7.0 Revert sktime minimum requirement to 0.7.0 Sep 20, 2021
@@ -2,7 +2,7 @@ name: Nightly unit tests, windows

on:
schedule:
- cron: '0 3 * * *'
- cron: '0 7 * * *'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused as to why the linux nightlies would pass and the windows ones would fail given that a fix was merged in #2808. It's because they ran at different times. I updated this to run at 3 am EST (note the github yaml expects UTC time).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, my half-asleep PR was merged in at 1am 😂

y_shuffled = y.sample(frac=1, replace=False)
detrender.fit_transform(X, y_shuffled)
assert "monotonically" in str(exec_info.value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL word. 👍

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! I think this makes much more sense 😂 🙏

@freddyaboulton freddyaboulton merged commit ad797e1 into main Sep 20, 2021
@freddyaboulton freddyaboulton deleted the fix-sktime-upgrade branch September 20, 2021 16:00
@chukarsten chukarsten mentioned this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants