Skip to content

Revert sktime minimum requirement to 0.7.0 #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freddyaboulton merged 5 commits into from
Sep 20, 2021
Merged

Revert sktime minimum requirement to 0.7.0 #2811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
496110d
Update error message
freddyaboulton Sep 20, 2021
754625f
Add 2811 to RL
freddyaboulton Sep 20, 2021
49dffcf
Update minimum requirements
freddyaboulton Sep 20, 2021
3efa4b4
Fix test
freddyaboulton Sep 20, 2021
40068b2
Change nightlies to run at 3 am EST
freddyaboulton Sep 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/windows_nightlies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Nightly unit tests, windows

on:
schedule:
- cron: '0 3 * * *'
- cron: '0 7 * * *'
Copy link
Contributor Author

@freddyaboulton freddyaboulton Sep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused as to why the linux nightlies would pass and the windows ones would fail given that a fix was merged in #2808. It's because they ran at different times. I updated this to run at 3 am EST (note the github yaml expects UTC time).

Copy link
Contributor

@angela97lin angela97lin Sep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, my half-asleep PR was merged in at 1am 😂


jobs:
win_unit_tests:
Expand Down
1 change: 1 addition & 0 deletions docs/source/release_notes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ Release Notes
* Deleted ``EmptyDataChecks`` class :pr:`2794`
* Documentation Changes
* Testing Changes
* Updated matched assertion message regarding monotonic indices in polynomial detrender tests :pr:`2811`

.. warning::

Expand Down
6 changes: 2 additions & 4 deletions evalml/tests/component_tests/test_polynomial_detrender.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,10 @@ def test_polynomial_detrender_needs_monotonic_index(ts_data):
X, y = ts_data
detrender = PolynomialDetrender(degree=2)

with pytest.raises(
ValueError,
match="The \\(time\\) index of input must be sorted monotonically increasing",
):
with pytest.raises(ValueError) as exec_info:
y_shuffled = y.sample(frac=1, replace=False)
detrender.fit_transform(X, y_shuffled)
assert "monotonically" in str(exec_info.value)
Copy link
Contributor

@angela97lin angela97lin Sep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL word. 👍


with pytest.raises(
NotImplementedError,
Expand Down
2 changes: 1 addition & 1 deletion evalml/tests/dependency_update_check/minimum_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ category_encoders==2.2.2
statsmodels==0.12.2
imbalanced-learn==0.8.0
pmdarima==1.8.0
sktime==0.8.0
sktime==0.7.0