-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "DROP_ROWS" action to output of OutliersDataCheck
#2820
Add "DROP_ROWS" action to output of OutliersDataCheck
#2820
Conversation
…hub.com:alteryx/evalml into 2677_add_drop_row_action_to_outliers_data_check
Codecov Report
@@ Coverage Diff @@
## main #2820 +/- ##
=======================================
+ Coverage 99.8% 99.8% +0.1%
=======================================
Files 297 297
Lines 27720 27737 +17
=======================================
+ Hits 27643 27660 +17
Misses 77 77
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's clear that you started with clear code and a solid design as this was super easy to complete! Very nice. I'm really excited about Datacheck/actions and how it's progressing.
I think the only thing I'd like to see resolved would be the issue with duplicate rows going into the Datacheck. That might already be determined so I'm going to go back through the issue now, so if it is, ping me and I'll re-review.
…hub.com:alteryx/evalml into 2677_add_drop_row_action_to_outliers_data_check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM
Closes #2677