Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "DROP_ROWS" action to output of OutliersDataCheck #2820

Merged
merged 9 commits into from Sep 22, 2021

Conversation

angela97lin
Copy link
Contributor

Closes #2677

@angela97lin angela97lin self-assigned this Sep 21, 2021
@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #2820 (a19370c) into main (8f3e487) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2820     +/-   ##
=======================================
+ Coverage   99.8%   99.8%   +0.1%     
=======================================
  Files        297     297             
  Lines      27720   27737     +17     
=======================================
+ Hits       27643   27660     +17     
  Misses        77      77             
Impacted Files Coverage Δ
evalml/data_checks/outliers_data_check.py 100.0% <100.0%> (ø)
...ests/data_checks_tests/test_outliers_data_check.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f3e487...a19370c. Read the comment docs.

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's clear that you started with clear code and a solid design as this was super easy to complete! Very nice. I'm really excited about Datacheck/actions and how it's progressing.

I think the only thing I'd like to see resolved would be the issue with duplicate rows going into the Datacheck. That might already be determined so I'm going to go back through the issue now, so if it is, ping me and I'll re-review.

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it.

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@angela97lin angela97lin merged commit b5410e1 into main Sep 22, 2021
@angela97lin angela97lin deleted the 2677_add_drop_row_action_to_outliers_data_check branch September 22, 2021 19:45
@chukarsten chukarsten mentioned this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "DROP_ROW" action to OutliersDataCheck
3 participants