Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve _ESTIMATOR_FAMILY_ORDER in IterativeAlgorithm #2850

Merged
merged 6 commits into from
Oct 21, 2021

Conversation

freddyaboulton
Copy link
Contributor

@freddyaboulton freddyaboulton commented Sep 28, 2021

Pull Request Description

Fixes #2849

Controversial perf tests here: https://alteryx.atlassian.net/wiki/spaces/PS/pages/1061093724/2849+Preserve+Pipeline+Order 😂


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #2850 (ce12981) into main (21aca40) will increase coverage by 0.8%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2850     +/-   ##
=======================================
+ Coverage   99.0%   99.7%   +0.8%     
=======================================
  Files        302     302             
  Lines      28626   28637     +11     
=======================================
+ Hits       28315   28544    +229     
+ Misses       311      93    -218     
Impacted Files Coverage Δ
...lml/automl/automl_algorithm/iterative_algorithm.py 100.0% <ø> (ø)
evalml/automl/automl_search.py 99.9% <100.0%> (+0.2%) ⬆️
evalml/tests/automl_tests/test_automl.py 99.5% <100.0%> (+0.1%) ⬆️
...lml/tests/automl_tests/test_iterative_algorithm.py 100.0% <100.0%> (+5.4%) ⬆️
evalml/automl/utils.py 100.0% <0.0%> (+1.7%) ⬆️
evalml/tests/automl_tests/test_automl_utils.py 100.0% <0.0%> (+9.5%) ⬆️
.../automl_tests/test_automl_search_classification.py 100.0% <0.0%> (+10.6%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21aca40...ce12981. Read the comment docs.

@freddyaboulton
Copy link
Contributor Author

Perf tests have been updated with results from a new default model family order.

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm fine with changing the order to get generally-better model performance. I left a comment on removing the excess commented code, but the implementation looks great!

estimators_in_first_batch
== linear_models + extra_dep_estimators + core_estimators
)
# if problem_type == ProblemTypes.BINARY:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these comments be removed?

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should hold off on this one....

@freddyaboulton
Copy link
Contributor Author

Sounds good @chukarsten ! When do you think would be a good time to merge this?

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, cool. I think we can move forward with this. Are you intending to keep those commented if clauses? I think just tidy that up and we're gucci.

@freddyaboulton freddyaboulton force-pushed the preserve-pipeline-order branch 2 times, most recently from ca00283 to ceb4175 Compare October 20, 2021 16:37
@freddyaboulton
Copy link
Contributor Author

@alteryx/evalml I re-ran the perf tests after merging in the latest main since it had been a while. Results from the previous analysis still hold. Anyone have any thoughts before I merge later today or tomorrow?

@freddyaboulton freddyaboulton force-pushed the preserve-pipeline-order branch 2 times, most recently from ddc4221 to 4329182 Compare October 21, 2021 15:07
@freddyaboulton freddyaboulton deleted the preserve-pipeline-order branch October 21, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoMLSearch does not respect the desired estimator family order
3 participants