Check conda versions match pip versions - #2851
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2851 +/- ##
=====================================
Coverage 99.8% 99.8%
=====================================
Files 302 302
Lines 28148 28148
=====================================
Hits 28070 28070
Misses 78 78 Continue to review full report at Codecov.
|
freddyaboulton
force-pushed
the
check-conda-pip-versions
branch
from
September 28, 2021 19:03
9eb136b to
853f30d
Compare
freddyaboulton
marked this pull request as ready for review
September 28, 2021 20:49
chukarsten
approved these changes
Sep 28, 2021
chukarsten
left a comment
Contributor
There was a problem hiding this comment.
This is really cool. Thanks for doing this Freddy. I guess you got tired of all of us asking you how to handle the feedstock X-D.
freddyaboulton
requested review from
ParthivNaresh,
angela97lin,
bchen1116,
christopherbunn,
dsherry,
eccabay and
jeremyliweishih
September 28, 2021 21:11
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add a CI job to check that the versions listed in our requirements files (used to install via pip) match the versions listed in our conda recipe (used to install via conda).
This is important because these should be equal to avoid the conda recipe getting stale. XGBoost is a good example of this. In pip, we list
>=1.4.2but in conda, we have<1.3.0.The goal is to check that our pip dependencies match the conda dependencies in
latest_release_changeswhenever we update one of our dependencies.We check
latest_release_changesinstead ofmasterbecause thelatest_release_changesbranch keeps track of all the changes we need to make prior to making the next conda release.When we go do the next conda release in the feedstock, CI will run to check that the PR has the same dependencies as
latest_release_changesExample where the check failed
https://github.com/alteryx/evalml/runs/3735325116?check_suite_focus=true
Example where the check passed
https://github.com/alteryx/evalml/runs/3735846986?check_suite_focus=true
Example of build_conda_pkg passing
https://github.com/alteryx/evalml/runs/3735847310?check_suite_focus=true
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.