Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check conda versions match pip versions #2851

merged 16 commits into from Sep 28, 2021


Copy link

@freddyaboulton freddyaboulton commented Sep 28, 2021

Pull Request Description

Add a CI job to check that the versions listed in our requirements files (used to install via pip) match the versions listed in our conda recipe (used to install via conda).

This is important because these should be equal to avoid the conda recipe getting stale. XGBoost is a good example of this. In pip, we list >=1.4.2 but in conda, we have <1.3.0.

The goal is to check that our pip dependencies match the conda dependencies in latest_release_changes whenever we update one of our dependencies.

We check latest_release_changes instead of master because the latest_release_changes branch keeps track of all the changes we need to make prior to making the next conda release.

When we go do the next conda release in the feedstock, CI will run to check that the PR has the same dependencies as latest_release_changes

Example where the check failed

Example where the check passed

Example of build_conda_pkg passing

After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #2851 (f9653d7) into main (81ad24f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2851   +/-   ##
  Coverage   99.8%   99.8%           
  Files        302     302           
  Lines      28148   28148           
  Hits       28070   28070           
  Misses        78      78           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81ad24f...f9653d7. Read the comment docs.

@freddyaboulton freddyaboulton marked this pull request as ready for review September 28, 2021 20:49
Copy link

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool. Thanks for doing this Freddy. I guess you got tired of all of us asking you how to handle the feedstock X-D.

@chukarsten chukarsten mentioned this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants