Skip to content

Rename automl classes and methods #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Dec 16, 2019
Merged

Conversation

kmax12
Copy link
Contributor

@kmax12 kmax12 commented Dec 16, 2019

Continuation of #282 which I accidentally closed

@kmax12 kmax12 requested a review from dsherry December 16, 2019 15:40
@@ -43,7 +43,8 @@
"metadata": {},
"outputs": [],
"source": [
"import evalml"
"import evalml\n",
"from evalml import AutoClassificationSearch, AutoRegressionSearch"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we follow this pattern in general in the docs? from evalml import Class?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking it would be good to have a standard if we don't have one already.

@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #287 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #287   +/-   ##
=======================================
  Coverage   96.99%   96.99%           
=======================================
  Files          95       95           
  Lines        2932     2932           
=======================================
  Hits         2844     2844           
  Misses         88       88
Impacted Files Coverage Δ
evalml/automl/apply.py 25% <ø> (ø)
.../tests/automl_tests/test_auto_regression_search.py 100% <100%> (ø)
evalml/automl/auto_classification_search.py 100% <100%> (ø)
evalml/__init__.py 100% <100%> (ø) ⬆️
evalml/tests/objective_tests/test_lead_scoring.py 100% <100%> (ø) ⬆️
...alml/tests/objective_tests/test_fraud_detection.py 100% <100%> (ø) ⬆️
evalml/automl/auto_regression_search.py 100% <100%> (ø)
evalml/automl/pipeline_search_plots.py 97.6% <100%> (ø)
evalml/automl/__init__.py 100% <100%> (ø)
...l/tests/automl_tests/test_pipeline_search_plots.py 97.24% <100%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7f1b2c...3a20b3f. Read the comment docs.

* ``AutoClassifier`` has been renamed to ``AutoClassificationSearch``
* ``AutoRegressor`` has been renamed to ``AutoRegressionSearch``
* ``AutoClassificationSearch.results`` and ``AutoRegressionSearch.results`` now is a dictionary with ``pipeline_results`` and ``search_order`` keys. ``pipeline_results`` can be used to access a dictionary that is identical to the old ``.results`` dictionary. Whereas,``search_order`` returns a list of the search order in terms of pipeline id.
* Pipelines now require an estimator as the last component in `component_list`. Slicing pipelines now throws an NotImplementedError to avoid returning Pipelines without an estimator.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipelines now require an estimator as the last component in component_list.

That's from one of @angela97lin's PRs?

Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kmax12 kmax12 merged commit 632afc4 into master Dec 16, 2019
@angela97lin angela97lin mentioned this pull request Dec 16, 2019
@dsherry dsherry deleted the rename-automl-classes-and-methods branch May 26, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants