-
Notifications
You must be signed in to change notification settings - Fork 90
Rename automl classes and methods #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -43,7 +43,8 @@ | |||
"metadata": {}, | |||
"outputs": [], | |||
"source": [ | |||
"import evalml" | |||
"import evalml\n", | |||
"from evalml import AutoClassificationSearch, AutoRegressionSearch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we follow this pattern in general in the docs? from evalml import Class
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just thinking it would be good to have a standard if we don't have one already.
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
=======================================
Coverage 96.99% 96.99%
=======================================
Files 95 95
Lines 2932 2932
=======================================
Hits 2844 2844
Misses 88 88
Continue to review full report at Codecov.
|
* ``AutoClassifier`` has been renamed to ``AutoClassificationSearch`` | ||
* ``AutoRegressor`` has been renamed to ``AutoRegressionSearch`` | ||
* ``AutoClassificationSearch.results`` and ``AutoRegressionSearch.results`` now is a dictionary with ``pipeline_results`` and ``search_order`` keys. ``pipeline_results`` can be used to access a dictionary that is identical to the old ``.results`` dictionary. Whereas,``search_order`` returns a list of the search order in terms of pipeline id. | ||
* Pipelines now require an estimator as the last component in `component_list`. Slicing pipelines now throws an NotImplementedError to avoid returning Pipelines without an estimator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pipelines now require an estimator as the last component in
component_list
.
That's from one of @angela97lin's PRs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Continuation of #282 which I accidentally closed