Update conda section of contributing guide #2899
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2899 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 302 302
Lines 28392 28392
=====================================
Hits 28296 28296
Misses 96 96 Continue to review full report at Codecov.
|
freddyaboulton
force-pushed
the
2898-update-conda-contributing-guide
branch
from
39027b0 to
5a240d8
Compare
freddyaboulton
requested review from
ParthivNaresh,
angela97lin,
bchen1116,
christopherbunn,
chukarsten,
dsherry,
eccabay and
jeremyliweishih
jeremyliweishih
left a comment
jeremyliweishih
left a comment
There was a problem hiding this comment.
love it! cleared up my understanding as well 👍
eccabay
left a comment
eccabay
left a comment
There was a problem hiding this comment.
LGTM! Just have one clarifying question, but this is a great overview.
contributing.md
Outdated
| make the check green. To add the dependency, clone the [feedstock](https://github.com/conda-forge/evalml-core-feedstock), | ||
| check out `latest_release_changes` and add the dependency to `evalml-core` if it is a core dependency or `evalml` if it is an | ||
| extra dependency. Push this change up and rerun `build_conda_pkg` on your branch. |
There was a problem hiding this comment.
To clarify, does this mean that updating the latest_release_changes branch from your local feedstock fork will somehow update the original feedstock repo's latest_release_changes? Or is there another step here that I'm missing?
There was a problem hiding this comment.
Ah great question! No need to fork in this case. Just push changes up to the "original" repo! I will clarify this point!
freddyaboulton
force-pushed
the
2898-update-conda-contributing-guide
branch
from
5a240d8 to
f5fb19d
Compare
Pull Request Description
Fixes #2898
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.