Add Drop Columns Transformer pipeline parameters for DefaultAlgorithm#2945
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2945 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 307 307
Lines 29215 29244 +29
=======================================
+ Hits 29124 29153 +29
Misses 91 91
Continue to review full report at Codecov.
|
Drop Columns Transformer parameters to make_pipelineDrop Columns Transformer pipeline parameters for DefaultAlgorithm
eccabay
left a comment
There was a problem hiding this comment.
LGTM! Just one clarifying question about a copied line
chukarsten
left a comment
There was a problem hiding this comment.
Looks good to me. I think we might want to file an issue to consider how to refactor the chunk moved into the private function to be shared between both Algorithms. That might help us think more about the lift & shift modularity that we wanted in the Algorithm base.
| next_batch.append(ensemble) | ||
| return next_batch | ||
|
|
||
| def _set_additional_pipeline_params(self): |
There was a problem hiding this comment.
This looks like functionality from IterativeAlgorithm's _create_pipelines() function. Should we figure out how to refactor both these algorithm's to call the common function? This isn't blocking as the code chunk was already in there, but it would probably be worth an issue.
Fixes #2939.