Conversation
Codecov Report
@@ Coverage Diff @@
## main #2958 +/- ##
=======================================
- Coverage 99.7% 99.0% -0.7%
=======================================
Files 307 309 +2
Lines 29288 29312 +24
=======================================
- Hits 29197 29003 -194
- Misses 91 309 +218
Continue to review full report at Codecov.
|
angela97lin
left a comment
There was a problem hiding this comment.
@eccabay Curious, is there a way to incorporate the idea of no splitting without introducing another splitter? That is, is there a way to change AutoMLSearch s.t. to take in a splitter, and if the splitter is None then we don't split?
|
@angela97lin great question! It is possible, I just spent some time playing around with my innovation days branch and proving that it could work. It involves a little refactoring of |
chukarsten
left a comment
There was a problem hiding this comment.
The data splitter that doesn't split! What functionality! So brave. Wow. All joking aside, this looks like this does what you want to do! Definitely would be good to see where this fits into an unsupervised learning epic, but I certainly trust you. I agree with Freddy that returning an empty array better conveys what this splitter is doing. I think the get_n_splits() should also probably return 1!
|
@eccabay Gotcha, that makes sense. I think this is great, and love how it makes it simple to not split data within our current structure without much refactoring. If this us to unsupervised learning support more quickly, I'm all on board! We can always support not having a splitter and refactor afterwards 😁 |
chukarsten
left a comment
There was a problem hiding this comment.
Thanks for making the changes!
Closes #2956
First step of adding unsupervised learning to evalml, this code is lifted directly from my innovation days branch.