Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add util tests and move utils to one file #297

merged 5 commits into from Jan 22, 2020

Add util tests and move utils to one file #297

merged 5 commits into from Jan 22, 2020


Copy link

@angela97lin angela97lin commented Dec 18, 2019

Closes #284.

Decided to leave logging as its own module (since it has its own class of functions), so currently only convert_to_seconds, but more utils will be added in #247 :)

@angela97lin angela97lin self-assigned this Dec 18, 2019
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #297 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #297      +/-   ##
+ Coverage   97.01%   97.06%   +0.05%     
  Files          96       96              
  Lines        2945     2963      +18     
+ Hits         2857     2876      +19     
+ Misses         88       87       -1
Impacted Files Coverage Δ
evalml/pipelines/classification/ 100% <ø> (ø) ⬆️
evalml/automl/ 100% <100%> (ø) ⬆️
...ts/automl_tests/ 100% <100%> (ø) ⬆️
...nents/estimators/classifiers/ 100% <100%> (ø) ⬆️
evalml/tests/pipeline_tests/ 100% <100%> (ø) ⬆️
evalml/tests/component_tests/ 100% <100%> (ø) ⬆️
evalml/automl/ 93.1% <0%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08ba7fa...988d252. Read the comment docs.

Copy link

@dsherry dsherry left a comment

This looks great to me as it is now. What else did you want to do in this PR @angela97lin ?

assert convert_to_seconds("10 h") == 36000
assert convert_to_seconds("10 hr") == 36000
assert convert_to_seconds("10 hour") == 36000
assert convert_to_seconds("10 hours") == 36000
Copy link

@dsherry dsherry Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!! Always a fan of more test coverage 🎆

Copy link
Contributor Author

angela97lin commented Jan 22, 2020

@dsherry I think this is sufficient for the sake of this PR, will merge and close :D

@angela97lin angela97lin merged commit dda9552 into master Jan 22, 2020
2 checks passed
@angela97lin angela97lin mentioned this pull request Mar 9, 2020
@dsherry dsherry deleted the utils branch May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Testing util functions utils folder
2 participants