-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add util tests and move utils to one file #297
Conversation
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
==========================================
+ Coverage 97.01% 97.06% +0.05%
==========================================
Files 96 96
Lines 2945 2963 +18
==========================================
+ Hits 2857 2876 +19
+ Misses 88 87 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me as it is now. What else did you want to do in this PR @angela97lin ?
assert convert_to_seconds("10 h") == 36000 | ||
assert convert_to_seconds("10 hr") == 36000 | ||
assert convert_to_seconds("10 hour") == 36000 | ||
assert convert_to_seconds("10 hours") == 36000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this!! Always a fan of more test coverage 🎆
@dsherry I think this is sufficient for the sake of this PR, will merge and close :D |
Closes #284.
Decided to leave logging as its own module (since it has its own class of functions), so currently only convert_to_seconds, but more utils will be added in #247 :)