Repository navigation
Limit model usage for EN, XBG, CB for large multiclass problems - #2982
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2982 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 309 309
Lines 29312 29399 +87
=======================================
+ Hits 29221 29308 +87
Misses 91 91
Continue to review full report at Codecov.
|
chukarsten
left a comment
There was a problem hiding this comment.
Thanks for knocking this one out!! A few things I'd like to see before we merge this: a little more documentation as noted in the review and a logger statement to appear in the verbose output of AutoML search. I think with that, in addition to all the good stuff you currently have, and this behavior is well documented and communicated clearly. Good call also making the filter_estimators function. We may need to conduct a similar test with the DefaultAlgorithm and move that function out of the IterativeAlgorithm to be used communally. An issue is filed for that : #2985 .
freddyaboulton
left a comment
There was a problem hiding this comment.
Thanks @bchen1116 ! Left some minor comments but otherwise looks great to me. I agree with the other threads on this pr as well.
…into bc_2976_limit_estimators
chukarsten
left a comment
There was a problem hiding this comment.
Looks gucci! Thanks for addressing. Sorry for the long wait on re-review.
fix #2976