Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on psutil package #3093

Merged
merged 7 commits into from
Nov 24, 2021
Merged

Remove dependency on psutil package #3093

merged 7 commits into from
Nov 24, 2021

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Nov 23, 2021

Closes #2993. Rather than deprecating the utils, I just removed the dependency on psutils which we used to show CPU metrics (# cores, memory).

Happy to discuss idea of removing the CLI entirely too!

@angela97lin angela97lin self-assigned this Nov 23, 2021
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #3093 (0887f11) into main (512ae29) will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3093     +/-   ##
=======================================
- Coverage   99.8%   99.8%   -0.0%     
=======================================
  Files        313     313             
  Lines      30492   30490      -2     
=======================================
- Hits       30402   30400      -2     
  Misses        90      90             
Impacted Files Coverage Δ
evalml/tests/utils_tests/test_cli_utils.py 100.0% <ø> (ø)
evalml/utils/cli_utils.py 100.0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 512ae29...0887f11. Read the comment docs.

@angela97lin angela97lin changed the title Remove dependency on psutils package Remove dependency on psutil package Nov 23, 2021
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @angela97lin !

@chukarsten chukarsten merged commit 57aab5e into main Nov 24, 2021
@chukarsten chukarsten mentioned this pull request Nov 29, 2021
@angela97lin angela97lin deleted the 2993_deprecate_cli branch January 11, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate the CLI
3 participants