Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable time series pipeline to predict on data with features that are not known-in-advanced #3094

Merged
merged 5 commits into from Nov 24, 2021

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

Fixes #3075


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@freddyaboulton freddyaboulton changed the title Implementation + unit tests Enable time series pipeline to predict on data with features that are not known-in-advanced Nov 23, 2021
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #3094 (1b19bc4) into main (fcfb9dc) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3094     +/-   ##
=======================================
+ Coverage   99.8%   99.8%   +0.1%     
=======================================
  Files        313     313             
  Lines      30483   30492      +9     
=======================================
+ Hits       30393   30402      +9     
  Misses        90      90             
Impacted Files Coverage Δ
evalml/pipelines/time_series_pipeline_base.py 100.0% <100.0%> (ø)
.../integration_tests/test_time_series_integration.py 100.0% <100.0%> (ø)
.../tests/pipeline_tests/test_time_series_pipeline.py 99.8% <100.0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcfb9dc...1b19bc4. Read the comment docs.

problem_configuration={
"max_delay": 5,
"gap": 3,
"forecast_horizon": 2,
"date_index": "date",
},
optimize_thresholds=False,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of #3095

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like the quick fix

Copy link
Contributor

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid!

@freddyaboulton freddyaboulton merged commit a6f93c7 into main Nov 24, 2021
@freddyaboulton freddyaboulton deleted the 3075-predict-with-not-known-in-advanced branch November 24, 2021 16:51
@chukarsten chukarsten mentioned this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeseries pipeline predict cannot handle missing features that are not known in advanced.
4 participants