Limit model usage for large multiclass problems Default Algo#3099
Merged
Limit model usage for large multiclass problems Default Algo#3099
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3099 +/- ##
=======================================
+ Coverage 99.8% 99.8% +0.1%
=======================================
Files 326 326
Lines 31698 31734 +36
=======================================
+ Hits 31607 31643 +36
Misses 91 91
Continue to review full report at Codecov.
|
jeremyliweishih
approved these changes
Jan 24, 2022
Collaborator
jeremyliweishih
left a comment
There was a problem hiding this comment.
This looks great to me @bchen1116! Only left a note about a utility add_result method in test_default_algorithm.
eccabay
approved these changes
Jan 24, 2022
Contributor
eccabay
left a comment
There was a problem hiding this comment.
Super interesting stuff!
chukarsten
approved these changes
Jan 24, 2022
Contributor
chukarsten
left a comment
There was a problem hiding this comment.
This looks good to me. Just a comment about parametrizing the first test! I love that we're making efforts to and succeeding at reusing code.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2985