Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit model usage for large multiclass problems Default Algo #3099

Merged
merged 15 commits into from
Jan 25, 2022

Conversation

bchen1116
Copy link
Contributor

fix #2985

@bchen1116 bchen1116 self-assigned this Nov 24, 2021
@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #3099 (9267fe1) into main (d14dbf2) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3099     +/-   ##
=======================================
+ Coverage   99.8%   99.8%   +0.1%     
=======================================
  Files        326     326             
  Lines      31698   31734     +36     
=======================================
+ Hits       31607   31643     +36     
  Misses        91      91             
Impacted Files Coverage Δ
evalml/automl/automl_search.py 99.9% <ø> (ø)
evalml/automl/automl_algorithm/automl_algorithm.py 100.0% <100.0%> (ø)
...valml/automl/automl_algorithm/default_algorithm.py 100.0% <100.0%> (ø)
...lml/automl/automl_algorithm/iterative_algorithm.py 100.0% <100.0%> (ø)
.../automl_tests/test_automl_search_classification.py 100.0% <100.0%> (ø)
...valml/tests/automl_tests/test_default_algorithm.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d14dbf2...9267fe1. Read the comment docs.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me @bchen1116! Only left a note about a utility add_result method in test_default_algorithm.

evalml/tests/automl_tests/test_default_algorithm.py Outdated Show resolved Hide resolved
Copy link
Contributor

@eccabay eccabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super interesting stuff!

docs/source/release_notes.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Just a comment about parametrizing the first test! I love that we're making efforts to and succeeding at reusing code.

@bchen1116 bchen1116 merged commit b6f290f into main Jan 25, 2022
@chukarsten chukarsten mentioned this pull request Feb 4, 2022
@freddyaboulton freddyaboulton deleted the bc_2985_memory_usage branch May 13, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Determine if DefaultAlgorithm is subject to memory usage issues
4 participants