Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tests that are not supposed to run during conda #3127

merged 4 commits into from Dec 7, 2021


Copy link

Pull Request Description

Fixes broken conda build ( after #3126

After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #3127 (69073fe) into main (16e7e67) will decrease coverage by 0.1%.
The diff coverage is 63.7%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3127     +/-   ##
- Coverage   99.7%   99.7%   -0.0%     
  Files        317     317             
  Lines      30679   30685      +6     
+ Hits       30579   30581      +2     
- Misses       100     104      +4     
Impacted Files Coverage Δ
evalml/tests/ 96.5% <33.4%> (-0.5%) ⬇️
...alml/tests/component_tests/ 100.0% <100.0%> (ø) 100.0% <100.0%> (ø)
...nent_tests/ 100.0% <100.0%> (ø)
..._tests/ 100.0% <100.0%> (ø)
...ts/component_tests/ 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16e7e67...69073fe. Read the comment docs.

skip_conda = pytest.mark.skip(reason="Test does not run during conda")
for item in items:
if "skip_during_conda" in item.keywords:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have coverage for this in build_conda_pkg:

@freddyaboulton freddyaboulton self-assigned this Dec 7, 2021
@freddyaboulton freddyaboulton marked this pull request as ready for review December 7, 2021 20:01
@freddyaboulton freddyaboulton added the blocker An issue blocking a release. label Dec 7, 2021
Copy link

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing!!

@freddyaboulton freddyaboulton merged commit c44f74b into main Dec 7, 2021
@freddyaboulton freddyaboulton deleted the skip-during-conda-with-marker branch December 7, 2021 20:53
@chukarsten chukarsten mentioned this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
blocker An issue blocking a release.
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants