Skip to content

Conversation

@freddyaboulton
Copy link
Contributor

Pull Request Description

Fixes broken conda build (https://github.com/alteryx/evalml/runs/4447336097?check_suite_focus=true) after #3126


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #3127 (69073fe) into main (16e7e67) will decrease coverage by 0.1%.
The diff coverage is 63.7%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3127     +/-   ##
=======================================
- Coverage   99.7%   99.7%   -0.0%     
=======================================
  Files        317     317             
  Lines      30679   30685      +6     
=======================================
+ Hits       30579   30581      +2     
- Misses       100     104      +4     
Impacted Files Coverage Δ
evalml/tests/conftest.py 96.5% <33.4%> (-0.5%) ⬇️
...alml/tests/component_tests/test_arima_regressor.py 100.0% <100.0%> (ø)
...ml/tests/component_tests/test_prophet_regressor.py 100.0% <100.0%> (ø)
...nent_tests/test_vowpal_wabbit_binary_classifier.py 100.0% <100.0%> (ø)
..._tests/test_vowpal_wabbit_multiclass_classifier.py 100.0% <100.0%> (ø)
...ts/component_tests/test_vowpal_wabbit_regressor.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16e7e67...69073fe. Read the comment docs.

skip_conda = pytest.mark.skip(reason="Test does not run during conda")
for item in items:
if "skip_during_conda" in item.keywords:
item.add_marker(skip_conda)
Copy link
Contributor Author

@freddyaboulton freddyaboulton Dec 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have coverage for this in build_conda_pkg: https://github.com/alteryx/evalml/runs/4448106079?check_suite_focus=true

@freddyaboulton freddyaboulton force-pushed the skip-during-conda-with-marker branch from e8154c2 to 69073fe Compare December 7, 2021 19:21
@freddyaboulton freddyaboulton self-assigned this Dec 7, 2021
@freddyaboulton freddyaboulton marked this pull request as ready for review December 7, 2021 20:01
@freddyaboulton freddyaboulton added the blocker An issue blocking a release. label Dec 7, 2021
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing!!

@freddyaboulton freddyaboulton merged commit c44f74b into main Dec 7, 2021
@freddyaboulton freddyaboulton deleted the skip-during-conda-with-marker branch December 7, 2021 20:53
@chukarsten chukarsten mentioned this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocker An issue blocking a release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants