-
Notifications
You must be signed in to change notification settings - Fork 90
Skip tests that are not supposed to run during conda #3127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3127 +/- ##
=======================================
- Coverage 99.7% 99.7% -0.0%
=======================================
Files 317 317
Lines 30679 30685 +6
=======================================
+ Hits 30579 30581 +2
- Misses 100 104 +4
Continue to review full report at Codecov.
|
| skip_conda = pytest.mark.skip(reason="Test does not run during conda") | ||
| for item in items: | ||
| if "skip_during_conda" in item.keywords: | ||
| item.add_marker(skip_conda) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have coverage for this in build_conda_pkg: https://github.com/alteryx/evalml/runs/4448106079?check_suite_focus=true
e8154c2 to
69073fe
Compare
jeremyliweishih
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing!!
Pull Request Description
Fixes broken conda build (https://github.com/alteryx/evalml/runs/4447336097?check_suite_focus=true) after #3126
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.