Fixed Windows CircleCI errors, and add tests for utils #313
Conversation
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
=======================================
Coverage 97.06% 97.06%
=======================================
Files 96 96
Lines 2963 2963
=======================================
Hits 2876 2876
Misses 87 87Continue to review full report at Codecov.
|
| command: | | ||
| C:\Users\circleci\Miniconda3\shell\condabin\conda-hook.ps1 | ||
| conda activate curr_py | ||
| conda install -c anaconda py-xgboost |
There was a problem hiding this comment.
Is this run command invoked somewhere during circleci setup? I don't see this PR adding a call to it anywhere. (I'm guessing that's because I don't understand yet how circleci works with this config :) )
There was a problem hiding this comment.
When CircleCI runs a workflow it automatically runs all of the steps within a job. So this run command is invoked as part of the win_unit_tests job
|
we probably want to add something about this to an install page in the docs for any windows users of evalml this is also a good reason to have minimal required dependencies in requirement.txt since some users may have difficult installing some third part libraries. related to discussion in #315 |
dsherry
changed the title
There was a problem hiding this comment.
@christopherbunn I agree with Max's comment: can you please add a short note to the doc about the Windows pip xgboost issue? My suggestion: in the documentation front page, at the end of the Install section (after the pip command), add something like: "A note for Windows users: the xgboost library may not be pip-installable in some environments. If so, please install it from Github instead."
(with the links).
After that this PR is ready to go.
Also, a note: technically this PR includes two separate code changes: a) fixing Windows CircleCI errors, and b) testing for utils. Please put separate issues in separate PRs in the future :) it makes it easy to understand the history on master.
Thanks!
|
@dsherry Added the requested line at the end of the install section. Now that you brought it up, I am now noticing that there are testing changes for the utils. I didn't write these changes, in fact they are exactly the same as the current changes in master. This branch is the first time I've tried to rebase the branch, could it be that I did that process incorrectly? |
christopherbunn
force-pushed
the
sklearn-win-circleci
branch
from
abc96d4
to
4323d40
Compare
After some testing in the Windows CircleCI instance, it turns out that there's some issues in installing XGBoost in Windows environments. As noted in the PyPi page, pip installation doesn't always work in Windows.
This commit installs XGBoost beforehand using Conda as a workaround for the pip install previously used.