Add DataCheckActionOption class#3134
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3134 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 322 324 +2
Lines 31101 31233 +132
=======================================
+ Hits 30996 31128 +132
Misses 105 105
Continue to review full report at Codecov.
|
…x/evalml into 3116_add_data_check_action_option
angela97lin
requested review from
ParthivNaresh,
bchen1116,
christopherbunn and
jeremyliweishih
and removed request for
christopherbunn
| bool: True if the other object is considered an equivalent data check action, False otherwise. | ||
| """ | ||
| return self.action_code == other.action_code and self.metadata == other.metadata | ||
| attributes_to_check = ["action_code", "data_check_name", "metadata"] |
There was a problem hiding this comment.
any new cases we should add to test_data_check_action_equality or test_data_check_action_inequality?
| def __init__(self, action_code, data_check_name, parameters=None, metadata=None): | ||
| self.action_code = action_code | ||
| self.data_check_name = data_check_name | ||
| self.parameters = parameters |
There was a problem hiding this comment.
Might be useful to leave the structure required for what a parameter looks like (esp since there's so much validation going on)
There was a problem hiding this comment.
Agreed, I think it'd be useful to show an example of an initialized DataCheckActionOption object with valid parameters
|
|
||
|
|
||
| def test_data_check_action_option_equality(dummy_data_check_name): | ||
| data_check_action_option = DataCheckActionOption( |
There was a problem hiding this comment.
I think the equality or inequality tests cover every case but it would be nice to double check since code coverage won't catch the cases because of how the loop is written!
bchen1116
left a comment
bchen1116
left a comment
There was a problem hiding this comment.
Great test coverage! Left a few questions for myself and nitpicky suggestions that might be helpful for this
| def __init__(self, action_code, data_check_name, parameters=None, metadata=None): | ||
| self.action_code = action_code | ||
| self.data_check_name = data_check_name | ||
| self.parameters = parameters |
There was a problem hiding this comment.
Agreed, I think it'd be useful to show an example of an initialized DataCheckActionOption object with valid parameters
3 participants
Part of #3116