Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize test_datasets #3145

Merged
merged 6 commits into from Dec 11, 2021
Merged

Parameterize test_datasets #3145

merged 6 commits into from Dec 11, 2021

Conversation

angela97lin
Copy link
Contributor

Closes #3025

@angela97lin angela97lin self-assigned this Dec 10, 2021
@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #3145 (aba4a9f) into main (e2a1630) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3145     +/-   ##
=======================================
- Coverage   99.7%   99.7%   -0.0%     
=======================================
  Files        318     318             
  Lines      30756   30692     -64     
=======================================
- Hits       30652   30588     -64     
  Misses       104     104             
Impacted Files Coverage Δ
evalml/tests/demo_tests/test_datasets.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2a1630...aba4a9f. Read the comment docs.

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for doing this!! Much nicer now.

@chukarsten chukarsten merged commit 8191339 into main Dec 11, 2021
@chukarsten chukarsten deleted the 3025_parameterize_test_datasets branch December 11, 2021 14:11
@angela97lin angela97lin mentioned this pull request Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameterize test_datasets
2 participants