Update nlp-primitives version to 2.1.0
#3166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3166 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 320 320
Lines 31030 31030
=====================================
Hits 30925 30925
Misses 105 105 Continue to review full report at Codecov.
|
freddyaboulton
approved these changes
Dec 21, 2021
Contributor
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
Thank you @angela97lin !!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to wait for
nlp-primitivesto upload to conda but requesting review so we can press go when it's out: https://anaconda.org/conda-forge/nlp-primitivesUp for debate: do we need to update our min version of
nlp-primitivesto 2.1.0? Technically, our CI will pass even if we don't (since it'll install the latest). Doing it here because I think it'd be safer / in case users get unexpected behavior with different versions of nlp-primitives and nltk.