Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nlp-primitives version to 2.1.0 #3166

Merged
merged 3 commits into from
Dec 22, 2021
Merged

Update nlp-primitives version to 2.1.0 #3166

merged 3 commits into from
Dec 22, 2021

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Dec 21, 2021

Need to wait for nlp-primitives to upload to conda but requesting review so we can press go when it's out: https://anaconda.org/conda-forge/nlp-primitives

Up for debate: do we need to update our min version of nlp-primitives to 2.1.0? Technically, our CI will pass even if we don't (since it'll install the latest). Doing it here because I think it'd be safer / in case users get unexpected behavior with different versions of nlp-primitives and nltk.

@angela97lin angela97lin self-assigned this Dec 21, 2021
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #3166 (10b6dc9) into main (d00cd59) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3166   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        320     320           
  Lines      31030   31030           
=====================================
  Hits       30925   30925           
  Misses       105     105           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d00cd59...10b6dc9. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review December 21, 2021 21:06
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @angela97lin !!

@angela97lin angela97lin merged commit f8343a7 into main Dec 22, 2021
@angela97lin angela97lin deleted the update_nlp_version branch December 22, 2021 02:09
@angela97lin angela97lin mentioned this pull request Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants