Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade minimum version of woodwork to v0.11.0 #3171

Merged
merged 4 commits into from Dec 22, 2021
Merged

Conversation

angela97lin
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #3171 (b4524c1) into main (f8343a7) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3171     +/-   ##
=======================================
- Coverage   99.7%   99.7%   -0.0%     
=======================================
  Files        320     320             
  Lines      31030   31029      -1     
=======================================
- Hits       30925   30924      -1     
  Misses       105     105             
Impacted Files Coverage Δ
evalml/tests/pipeline_tests/test_pipeline_utils.py 99.7% <100.0%> (-<0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8343a7...b4524c1. Read the comment docs.

@angela97lin angela97lin changed the title Fix tests from woodwork v0.11.0 Upgrade minimum version of woodwork to v0.11.0 Dec 22, 2021
@angela97lin angela97lin marked this pull request as ready for review December 22, 2021 21:05
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests pass!

* Documentation Changes
* Added comments to provide clarity on doctests :pr:`3155`
* Testing Changes
* Parameterized tests in ``test_datasets.py`` :pr:`3145`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra line?

[NaturalLanguageFeaturizer]
if "text" in column_names and input_type == "ww"
else []
[NaturalLanguageFeaturizer] if "text" in column_names else []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New natural language inference means even with pandas input, we'll infer natural language! Before, it was inferred as Unknown, hence the DropColumn transformer that got removed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds great, thanks!

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@angela97lin angela97lin merged commit 3b4108f into main Dec 22, 2021
@angela97lin angela97lin deleted the woodwork_v0.11.0 branch December 22, 2021 22:15
@angela97lin angela97lin mentioned this pull request Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants