Add auto approve workflow for dependency PRs#3184
Conversation
gsheni
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3184 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 326 326
Lines 31444 31444
=====================================
Hits 31340 31340
Misses 104 104 Continue to review full report at Codecov.
|
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
@gsheni Looks good to me! Left some non-blocking questions
| echo ${{ steps.find_prs.outputs.dep_pull_request }} | ||
| gh pr review --repo "${{ github.repository }}" --comment --body "auto approve" ${{ steps.find_prs.outputs.dep_pull_request }} | ||
| gh pr review --repo "${{ github.repository }}" --approve ${{ steps.find_prs.outputs.dep_pull_request }} | ||
| gh pr merge --repo "${{ github.repository }}" --auto --squash ${{ steps.find_prs.outputs.dep_pull_request }} |
There was a problem hiding this comment.
So this will error out if any of the CI checks are red? What if some are still running?
If this doesn't error out for pending checks, should we change the cron to run every 5 minutes? That way this gets merged as soon as CI finishes + passes.
There was a problem hiding this comment.
The status:success review:required means that it will only auto approve if all CI passes.
I can change it to run every 5 minutes.
There was a problem hiding this comment.
Will this auto-approve and merge if a reviewer approves but leaves comments on nit-picks/suggestions?
There was a problem hiding this comment.
This is only for dependency update PRs, such as this:
There was a problem hiding this comment.
My hope would be that EvalML reviewers are no longer touching those types of PRs (when they pass all CI checks).
bchen1116
left a comment
bchen1116
left a comment
There was a problem hiding this comment.
This is really cool! Left a nit and a question that would be useful to address
| * Documentation Changes | ||
| * Testing Changes | ||
|
|
||
| * Add workflow to auto-merge dependency PRs if status checks pass (:pr:`3184`) |
There was a problem hiding this comment.
tiny nit, but we don't put parentheses around the PR number.
| echo ${{ steps.find_prs.outputs.dep_pull_request }} | ||
| gh pr review --repo "${{ github.repository }}" --comment --body "auto approve" ${{ steps.find_prs.outputs.dep_pull_request }} | ||
| gh pr review --repo "${{ github.repository }}" --approve ${{ steps.find_prs.outputs.dep_pull_request }} | ||
| gh pr merge --repo "${{ github.repository }}" --auto --squash ${{ steps.find_prs.outputs.dep_pull_request }} |
There was a problem hiding this comment.
Will this auto-approve and merge if a reviewer approves but leaves comments on nit-picks/suggestions?
chukarsten
left a comment
chukarsten
left a comment
There was a problem hiding this comment.
Awesome, thanks for doing this!
4 participants
Uh oh!
There was an error while loading. Please reload this page.