Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightlies #3189

Merged
merged 7 commits into from
Jan 6, 2022
Merged

Fix nightlies #3189

merged 7 commits into from
Jan 6, 2022

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

Fix broken nightlies


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #3189 (c989ac5) into main (e383f24) will not change coverage.
The diff coverage is 50.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3189   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        326     326           
  Lines      31444   31444           
=====================================
  Hits       31340   31340           
  Misses       104     104           
Impacted Files Coverage Δ
evalml/tests/component_tests/test_utils.py 95.7% <ø> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 99.8% <50.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e383f24...c989ac5. Read the comment docs.

@freddyaboulton
Copy link
Contributor Author

Might be good to get this in before release/EOD so that the nightlies don't fail again tonight.

@@ -3,6 +3,8 @@ name: Nightly unit tests, linux
on:
schedule:
- cron: '0 7 * * *'
pull_request:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will revert changes in this file prior to merge.

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @freddyaboulton 🙏

if_mention: failure,cancelled
text: ':elmofire:'
if: failure()
# - name: Notify on Slack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this file will be reverted? 👀

"ARIMA Regressor",
"Polynomial Detrender",
]
["ARIMA Regressor", "Polynomial Detrender", "Exponential Smoothing Regressor"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, just curious on your thoughts @freddyaboulton: is there something we could have done to better catch this without using the nightlies? I guess not since we don't run 3.9 on each commit...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy that the error was pretty clear in the failure though: https://github.com/alteryx/evalml/runs/4728893144

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea maybe we should have expected the nightlies/conda to fail when we add an sktime component but ultimately I think it's ok that this was caught after merge during the nightlies. We decided to only test 3.9 during the nightlies to save on developer time for 95% of prs that don't exhibit any behavior between python < 3.9 and python 3.9 so fixing stuff is just part of the trade-off.

@freddyaboulton freddyaboulton merged commit 71c1bfc into main Jan 6, 2022
@freddyaboulton freddyaboulton deleted the fix-windows-3.9-nightlies-ets branch January 6, 2022 20:04
@freddyaboulton freddyaboulton added the blocker An issue blocking a release. label Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker An issue blocking a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants