Fix nightlies #3189
Fix nightlies #3189
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3189 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 326 326
Lines 31444 31444
=====================================
Hits 31340 31340
Misses 104 104
Continue to review full report at Codecov.
|
freddyaboulton
force-pushed
the
fix-windows-3.9-nightlies-ets
branch
from
7596c43 to
9cfc5a3
Compare
freddyaboulton
requested review from
ParthivNaresh,
angela97lin,
bchen1116,
christopherbunn,
chukarsten,
dsherry,
eccabay and
jeremyliweishih
|
Might be good to get this in before release/EOD so that the nightlies don't fail again tonight. |
| on: | ||
| schedule: | ||
| - cron: '0 7 * * *' | ||
| pull_request: |
There was a problem hiding this comment.
Will revert changes in this file prior to merge.
| if_mention: failure,cancelled | ||
| text: ':elmofire:' | ||
| if: failure() | ||
| # - name: Notify on Slack |
There was a problem hiding this comment.
I'm guessing this file will be reverted? 👀
| "ARIMA Regressor", | ||
| "Polynomial Detrender", | ||
| ] | ||
| ["ARIMA Regressor", "Polynomial Detrender", "Exponential Smoothing Regressor"] |
There was a problem hiding this comment.
Hmmm, just curious on your thoughts @freddyaboulton: is there something we could have done to better catch this without using the nightlies? I guess not since we don't run 3.9 on each commit...
There was a problem hiding this comment.
I am happy that the error was pretty clear in the failure though: https://github.com/alteryx/evalml/runs/4728893144
There was a problem hiding this comment.
Yea maybe we should have expected the nightlies/conda to fail when we add an sktime component but ultimately I think it's ok that this was caught after merge during the nightlies. We decided to only test 3.9 during the nightlies to save on developer time for 95% of prs that don't exhibit any behavior between python < 3.9 and python 3.9 so fixing stuff is just part of the trade-off.
Pull Request Description
Fix broken nightlies
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.