Standardize names of featurizer components#3192
Merged
Merged
Conversation
jeremyliweishih
approved these changes
Jan 7, 2022
jeremyliweishih
left a comment
Collaborator
There was a problem hiding this comment.
Looks great! There could be two more changes missing though!
freddyaboulton
approved these changes
Jan 7, 2022
freddyaboulton
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! Thank you @bchen1116 (and good eye @jeremyliweishih )
chukarsten
approved these changes
Jan 10, 2022
chukarsten
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Thanks Bryan!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changing the names of Datetime and NL featurization components to match URL and email featurizers