Skip to content

Standardize names of featurizer components#3192

Merged
bchen1116 merged 19 commits into
mainfrom
bc_2464_names
Jan 10, 2022
Merged

Standardize names of featurizer components#3192
bchen1116 merged 19 commits into
mainfrom
bc_2464_names

Conversation

@bchen1116

@bchen1116 bchen1116 commented Jan 6, 2022

Copy link
Copy Markdown
Contributor

changing the names of Datetime and NL featurization components to match URL and email featurizers

@bchen1116 bchen1116 self-assigned this Jan 6, 2022
@codecov

codecov Bot commented Jan 6, 2022

Copy link
Copy Markdown

Codecov Report

Merging #3192 (97d06c7) into main (02c2021) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3192   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        326     326           
  Lines      31135   31135           
=====================================
  Hits       31039   31039           
  Misses        96      96           
Impacted Files Coverage Δ
evalml/tests/component_tests/test_utils.py 95.7% <ø> (ø)
evalml/tests/conftest.py 95.9% <ø> (ø)
...s/prediction_explanations_tests/test_explainers.py 100.0% <ø> (ø)
.../prediction_explanations_tests/test_force_plots.py 100.0% <ø> (ø)
...l_understanding_tests/test_feature_explanations.py 100.0% <ø> (ø)
...lml/tests/model_understanding_tests/test_graphs.py 100.0% <ø> (ø)
...del_understanding_tests/test_partial_dependence.py 100.0% <ø> (ø)
...understanding_tests/test_permutation_importance.py 100.0% <ø> (ø)
...valml/tests/pipeline_tests/test_component_graph.py 99.9% <ø> (ø)
.../transformers/preprocessing/datetime_featurizer.py 100.0% <100.0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02c2021...97d06c7. Read the comment docs.

@jeremyliweishih jeremyliweishih left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! There could be two more changes missing though!

@freddyaboulton freddyaboulton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you @bchen1116 (and good eye @jeremyliweishih )

@chukarsten chukarsten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks Bryan!

@bchen1116 bchen1116 enabled auto-merge (squash) January 10, 2022 22:24
@bchen1116 bchen1116 merged commit bb0f4f7 into main Jan 10, 2022
@chukarsten chukarsten mentioned this pull request Jan 18, 2022
@freddyaboulton freddyaboulton deleted the bc_2464_names branch May 13, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants