Drop NaN before partial dependence grid generation#3235
Merged
freddyaboulton merged 4 commits intomainfrom Jan 13, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3235 +/- ##
=======================================
+ Coverage 99.8% 99.8% +0.1%
=======================================
Files 326 326
Lines 31395 31405 +10
=======================================
+ Hits 31304 31314 +10
Misses 91 91
Continue to review full report at Codecov.
|
freddyaboulton
force-pushed
the
3226-nan-feature-values-part-dep
branch
2 times, most recently
from
78d38ee to
2f83e52
Compare
freddyaboulton
requested review from
ParthivNaresh,
angela97lin,
bchen1116,
christopherbunn,
chukarsten,
dsherry,
eccabay,
jeremyliweishih and
travisje
and removed request for
bchen1116,
chukarsten and
travisje
freddyaboulton
force-pushed
the
3226-nan-feature-values-part-dep
branch
from
2f83e52 to
ae7bb65
Compare
freddyaboulton
force-pushed
the
3226-nan-feature-values-part-dep
branch
from
ae7bb65 to
1e88d65
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #3226
Model understanding perf tests here:
report.html.zip
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.