Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add n_obs and n_splits to TimeSeriesParametersDataCheck error details #3246

Merged
merged 2 commits into from
Jan 14, 2022

Conversation

fjlanasa
Copy link
Contributor

Pull Request Description

(replace this text with your description)


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #3246 (9f35ac1) into main (23e3d31) will not change coverage.
The diff coverage is 100.0%.

❗ Current head 9f35ac1 differs from pull request most recent head 65df8f1. Consider uploading reports for the commit 65df8f1 to get more accurate results
Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3246   +/-   ##
=====================================
  Coverage   99.8%   99.8%           
=====================================
  Files        326     326           
  Lines      31405   31405           
=====================================
  Hits       31314   31314           
  Misses        91      91           
Impacted Files Coverage Δ
evalml/data_checks/ts_parameters_data_check.py 100.0% <ø> (ø)
...data_checks_tests/test_ts_parameters_data_check.py 100.0% <ø> (ø)
evalml/utils/gen_utils.py 98.7% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e3d31...65df8f1. Read the comment docs.

@fjlanasa fjlanasa force-pushed the fl/update-ts-params-check-details branch 2 times, most recently from f422d8d to 52d44e9 Compare January 14, 2022 17:19
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fjlanasa Looks good and thanks for the contribution! You just gotta update the docstring tests here for CI to pass.

@fjlanasa fjlanasa enabled auto-merge (squash) January 14, 2022 20:09
@fjlanasa fjlanasa force-pushed the fl/update-ts-params-check-details branch from 9f35ac1 to 65df8f1 Compare January 14, 2022 20:17
@fjlanasa fjlanasa merged commit 01d8c87 into main Jan 14, 2022
@freddyaboulton freddyaboulton deleted the fl/update-ts-params-check-details branch January 14, 2022 21:14
@chukarsten chukarsten mentioned this pull request Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants