Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in separate by gap for time series #3256

Merged
merged 4 commits into from
Jan 20, 2022
Merged

Conversation

freddyaboulton
Copy link
Contributor

@freddyaboulton freddyaboulton commented Jan 19, 2022

Pull Request Description

Bug fix prior to release

Perf test

report.html.zip


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #3256 (fbbcf00) into main (5589a76) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3256     +/-   ##
=======================================
+ Coverage   99.8%   99.8%   +0.1%     
=======================================
  Files        326     326             
  Lines      31476   31477      +1     
=======================================
+ Hits       31385   31386      +1     
  Misses        91      91             
Impacted Files Coverage Δ
evalml/tests/utils_tests/test_gen_utils.py 100.0% <100.0%> (ø)
evalml/utils/gen_utils.py 98.8% <100.0%> (-<0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5589a76...fbbcf00. Read the comment docs.

@freddyaboulton freddyaboulton added the blocker An issue blocking a release. label Jan 19, 2022
Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG freddy! Thanks a ton!!!

@freddyaboulton freddyaboulton enabled auto-merge (squash) January 20, 2022 15:43
@freddyaboulton freddyaboulton merged commit 992b877 into main Jan 20, 2022
christopherbunn added a commit that referenced this pull request Feb 3, 2022
* Fix bug in separate by gap

* Add to release notes

* Undo notebook changes

* Fix bug in release notes
@freddyaboulton freddyaboulton deleted the separate-by-gap-fix branch May 13, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker An issue blocking a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants