Fix bug in separate by gap for time series - #3256
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3256 +/- ##
=======================================
+ Coverage 99.8% 99.8% +0.1%
=======================================
Files 326 326
Lines 31476 31477 +1
=======================================
+ Hits 31385 31386 +1
Misses 91 91
Continue to review full report at Codecov.
|
freddyaboulton
force-pushed
the
separate-by-gap-fix
branch
from
January 20, 2022 15:29
6b5448c to
fbbcf00
Compare
freddyaboulton
marked this pull request as ready for review
January 20, 2022 15:30
freddyaboulton
requested review from
ParthivNaresh,
angela97lin,
bchen1116,
christopherbunn,
chukarsten,
dsherry,
eccabay and
jeremyliweishih
and removed request for
ParthivNaresh and
bchen1116
January 20, 2022 15:30
chukarsten
approved these changes
Jan 20, 2022
chukarsten
left a comment
chukarsten
left a comment
Contributor
There was a problem hiding this comment.
LG freddy! Thanks a ton!!!
freddyaboulton
enabled auto-merge (squash)
January 20, 2022 15:43
christopherbunn
added a commit
that referenced
this pull request
Feb 3, 2022
* Fix bug in separate by gap * Add to release notes * Undo notebook changes * Fix bug in release notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Bug fix prior to release
Perf test
report.html.zip
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.