Removes ``DateTimeNaNDataCheck`` and ``NaturalLanguageNaNDataCheck`` by angela97lin · Pull Request #3260 · alteryx/evalml

angela97lin · 2022-01-19T20:40:18Z

Closes #3242. Currently pointing to my branch right now but will wait to merge into main after #3182 is merged!

* init * init * start updating tests * add validation code for option * remove data check updates for now * start to clean up tests and add validate_parameter tests * revert highly null dc * add in more valueerror test checking * fix test and logic for column parameters * init * update some tests to new API * fix more tests * fix doc and sparsity test * fix integration tests * fix doctests * fix doctests * fix ts splitting test and impl * fix more ts splitting tests * fix doctest for ts data check * release notes * update target leakage data check docstring for consistency * doctest linting and cleanup * linting

…taCheckAction` (#3152) * init * init * start updating tests * add validation code for option * remove data check updates for now * start to clean up tests and add validate_parameter tests * revert highly null dc * add in more valueerror test checking * fix test and logic for column parameters * init * update some tests to new API * fix more tests * fix doc and sparsity test * fix integration tests * fix doctests * init, update no variance * update highly null dc * fix id column dc * update target leakage dc * update sparsity dc * outliers and uniqueness dc * update target dis dc * update invalid target data check * fix doctests * fix ts splitting test and impl * fix dc validate and tests * fix more ts splitting tests * fix data check actions notebook * update to remove columns to drop * freeze * remove rows to drop * update dc tests * update doctests * fix integration tests * revert requirements * update parameters to set to empty dict * fix tests * fix doctests * retrigger * revert parameter for data check option * fix data check option test * fix more tests from updating default parameters * release notes * use empty instead of none * release notes * cleanup unnecessary code * move logic to data check option class and rename * update integration tests * add tests and some cleanup * fix tests * fix pipeline util test * remove unnecessary conditional * fix naming, need to fix tests * fix tests * fix doctest * add new enums * add logic for enums * update files to use enum * add in testing for invalid enum * fix doctest by updating to_dict impl * linting * try with different base * oops revert yaml * fix tests * remove outdated code * add more tests

… to return impute action for non-highly null columns. (#3197) * init * init * start updating tests * add validation code for option * remove data check updates for now * start to clean up tests and add validate_parameter tests * revert highly null dc * add in more valueerror test checking * fix test and logic for column parameters * init * update some tests to new API * fix more tests * fix doc and sparsity test * fix integration tests * fix doctests * init, update no variance * update highly null dc * fix id column dc * update target leakage dc * update sparsity dc * outliers and uniqueness dc * update target dis dc * update invalid target data check * fix doctests * fix ts splitting test and impl * fix dc validate and tests * fix more ts splitting tests * fix data check actions notebook * update to remove columns to drop * freeze * remove rows to drop * update dc tests * update doctests * fix integration tests * revert requirements * update parameters to set to empty dict * fix tests * fix doctests * retrigger * revert parameter for data check option * fix data check option test * fix more tests from updating default parameters * release notes * use empty instead of none * release notes * cleanup unnecessary code * move logic to data check option class and rename * init rename * retrigger * revert release nots * add new logic for detecting null cols * update integration tests * add tests and some cleanup * fix tests * fix pipeline util test * remove unnecessary conditional * fix test and iteration for null data check * fix naming, need to fix tests * fix tests * fix doctest * add new enums * add logic for enums * update files to use enum * add in testing for invalid enum * fix doctest by updating to_dict impl * linting * try with different base * oops revert yaml * fix tests * remove outdated code * oops fix merge * add more tests * fix null data check tests * update to use per column strategy and fix tests * fix tests for data checks * fix tests and doctests * release notes * fix release notes * oops update action code * oops fix test * update wording of messages * move logic out of dict * update mode to most_frequent for impute strategies * oops fix linting and doctests

* init * more cleanup * begin to clean up tests * fix more tests * updating naming to action_options and fixing more tests * fix no variance * fix another test * fixing automl tests * oops actually fix automl tests * fix the other automl tests * fixing notebook * fix data check tests * fix doctests and docs * integration tests and cleanup * cleanup based on comments * linting * clean up notebook and tests

…3237) * init * init * start updating tests * add validation code for option * remove data check updates for now * start to clean up tests and add validate_parameter tests * revert highly null dc * add in more valueerror test checking * fix test and logic for column parameters * init * update some tests to new API * fix more tests * fix doc and sparsity test * fix integration tests * fix doctests * init, update no variance * update highly null dc * fix id column dc * update target leakage dc * update sparsity dc * outliers and uniqueness dc * update target dis dc * update invalid target data check * fix doctests * fix ts splitting test and impl * fix dc validate and tests * fix more ts splitting tests * fix data check actions notebook * update to remove columns to drop * freeze * remove rows to drop * update dc tests * update doctests * fix integration tests * revert requirements * update parameters to set to empty dict * fix tests * fix doctests * retrigger * revert parameter for data check option * fix data check option test * fix more tests from updating default parameters * release notes * use empty instead of none * release notes * cleanup unnecessary code * move logic to data check option class and rename * init rename * retrigger * revert release nots * add new logic for detecting null cols * update integration tests * add tests and some cleanup * fix tests * fix pipeline util test * remove unnecessary conditional * fix test and iteration for null data check * fix naming, need to fix tests * fix tests * fix doctest * add new enums * add logic for enums * update files to use enum * add in testing for invalid enum * fix doctest by updating to_dict impl * linting * try with different base * oops revert yaml * fix tests * remove outdated code * oops fix merge * add more tests * fix null data check tests * update to use per column strategy and fix tests * fix tests for data checks * fix tests and doctests * release notes * fix release notes * init * init and fix testing * fix integration test * updates test * clean up docs * lint notebook * fix tests with types * linting * release notes * update wording * update impl for natural language and datetimes, remove old tests * fix tests * fix doctest

…lml into update_data_check_action_API

codecov · 2022-01-19T20:44:26Z

Codecov Report

Merging #3260 (a992cdb) into main (b6f290f) will decrease coverage by 0.1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main   #3260     +/-   ##
=======================================
- Coverage   99.8%   99.8%   -0.0%     
=======================================
  Files        326     322      -4     
  Lines      31734   31611    -123     
=======================================
- Hits       31643   31520    -123     
  Misses        91      91

Impacted Files	Coverage Δ
evalml/data_checks/__init__.py	`100.0% <ø> (ø)`
evalml/data_checks/default_data_checks.py	`100.0% <ø> (ø)`
evalml/tests/data_checks_tests/test_data_checks.py	`100.0% <ø> (ø)`
evalml/tests/pipeline_tests/test_pipeline_utils.py	`99.7% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6f290f...a992cdb. Read the comment docs.

angela97lin · 2022-01-20T19:34:20Z

docs/source/api_index.rst

-    evalml.data_checks.NaturalLanguageNaNDataCheck
    evalml.data_checks.DateTimeFormatDataCheck
    evalml.data_checks.TimeSeriesParametersDataCheck
+    evalml.data_checks.TimeSeriesSplittingDataCheck


Unrelated, just saw this was missing :)

jeremyliweishih

Looks good! Are we going to delete evalml/data_checks/datetime_nan_data_check.py as well?

eccabay

LGTM! 🚢

freddyaboulton

Looks good to me but I think we also need to remove DateTimeNaNDataCheck implementation. Thanks @angela97lin !

…_nl_dc

chukarsten · 2022-01-24T23:37:16Z

@angela97lin I fiddled with the conflict with the release notes so if you have anymore work, you might want to pull

angela97lin · 2022-01-25T00:08:52Z

@freddyaboulton Oops, good catch! Mildly concerning that codecov didn't fail even though the entire file was not covered...

And thank you @chukarsten! I've decided not to add any more PRs to my branch since I've gotten a substantial number of approvals on it so will wait until it's in main to merge this :)

angela97lin added 24 commits January 5, 2022 00:27

Merge branch 'main' into update_data_check_action_API

bace330

Merge branch 'main' into update_data_check_action_API

0614cf4

Merge branch 'main' into update_data_check_action_API

c8d9eb2

fix merging main issues

e1c373f

Merge branch 'main' into update_data_check_action_API

6558c9d

Merge branch 'main' into update_data_check_action_API

52de764

Merge branch 'main' into update_data_check_action_API

b48fa97

Merge branch 'main' into update_data_check_action_API

c98c96e

Merge branch 'main' into update_data_check_action_API

4f6952a

Merge branch 'main' into update_data_check_action_API

ad9eacb

Merge branch 'main' into update_data_check_action_API

b24c792

Merge branch 'main' into update_data_check_action_API

e70f3f6

Merge branch 'main' into update_data_check_action_API

3846ad1

merging main

556c437

merging

888d901

release notes

f993939

Merge branch 'update_data_check_action_API' of github.com:alteryx/eva…

8037346

…lml into update_data_check_action_API

minor cleanup

5208a1a

init

60c7ff0

angela97lin self-assigned this Jan 19, 2022

angela97lin changed the base branch from main to update_data_check_action_API January 19, 2022 20:40

release notes

5dd5cb7

angela97lin commented Jan 20, 2022

View reviewed changes

angela97lin marked this pull request as ready for review January 20, 2022 19:35

angela97lin requested review from bchen1116, chukarsten, dsherry, eccabay, freddyaboulton and jeremyliweishih January 20, 2022 19:35

release notes

6249d74

jeremyliweishih approved these changes Jan 21, 2022

View reviewed changes

eccabay approved these changes Jan 24, 2022

View reviewed changes

freddyaboulton approved these changes Jan 24, 2022

View reviewed changes

angela97lin added 2 commits January 24, 2022 11:39

Merge branch 'main' into update_data_check_action_API

5276a69

Merge branch 'main' into update_data_check_action_API

1094e7b

chukarsten approved these changes Jan 24, 2022

View reviewed changes

Merge branch 'update_data_check_action_API' into 3242_remove_datetime…

38146f0

…_nl_dc

oops delete file

95cceda

Base automatically changed from update_data_check_action_API to main January 25, 2022 17:50

angela97lin added 2 commits January 25, 2022 12:53

oops adding line removal

4435545

merging

a992cdb

angela97lin merged commit c46ed0c into main Jan 26, 2022

angela97lin deleted the 3242_remove_datetime_nl_dc branch January 26, 2022 05:43

chukarsten mentioned this pull request Feb 4, 2022

Release v0.44.0 #3306

Merged

This was referenced Feb 10, 2022

Update NullDataCheck so that natural language columns with nan values (but are not highly null) suggest dropping rows rather than imputation #3320

Closed

Update NullDataCheck so that datetime columns with nans suggest action other than imputation #3321

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removes `DateTimeNaNDataCheck` and `NaturalLanguageNaNDataCheck`#3260

Removes `DateTimeNaNDataCheck` and `NaturalLanguageNaNDataCheck`#3260
angela97lin merged 32 commits intomainfrom
3242_remove_datetime_nl_dc

angela97lin commented Jan 19, 2022 •

edited

Loading

Uh oh!

codecov bot commented Jan 19, 2022 •

edited

Loading

Uh oh!

angela97lin Jan 20, 2022

Uh oh!

jeremyliweishih left a comment

Uh oh!

eccabay left a comment

Uh oh!

freddyaboulton left a comment

Uh oh!

chukarsten commented Jan 24, 2022

Uh oh!

angela97lin commented Jan 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

angela97lin commented Jan 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

angela97lin Jan 20, 2022

Choose a reason for hiding this comment

Uh oh!

jeremyliweishih left a comment

Choose a reason for hiding this comment

Uh oh!

eccabay left a comment

Choose a reason for hiding this comment

Uh oh!

freddyaboulton left a comment

Choose a reason for hiding this comment

Uh oh!

chukarsten commented Jan 24, 2022

Uh oh!

angela97lin commented Jan 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

angela97lin commented Jan 19, 2022 •

edited

Loading

codecov bot commented Jan 19, 2022 •

edited

Loading