Skip to content

Update auto approve workflow trigger and delete branch after merge#3265

Merged
gsheni merged 4 commits intomainfrom
update_auto_approve
Jan 20, 2022
Merged

Update auto approve workflow trigger and delete branch after merge#3265
gsheni merged 4 commits intomainfrom
update_auto_approve

Conversation

@gsheni
Copy link
Copy Markdown
Contributor

@gsheni gsheni commented Jan 20, 2022 •
edited
Loading

  • Changes auto approve workflow to only run when dependency PRs are put up (and the unit tests on those PRs finish)
  • Delete branch after merging

@gsheni gsheni changed the title Update auto_approve_dependency_PRs.yml Update auto approve workflow trigger and delete branch after merge Jan 20, 2022
@gsheni gsheni self-assigned this Jan 20, 2022
@gsheni gsheni marked this pull request as ready for review January 20, 2022 15:05
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 20, 2022 •
edited
Loading

Codecov Report

Merging #3265 (8e2904b) into main (12b5156) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3265   +/-   ##
=====================================
  Coverage   99.8%   99.8%           
=====================================
  Files        326     326           
  Lines      31496   31496           
=====================================
  Hits       31405   31405           
  Misses        91      91

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b5156...8e2904b. Read the comment docs.

@gsheni gsheni enabled auto-merge (squash) January 20, 2022 15:08
@gsheni gsheni disabled auto-merge January 20, 2022 15:08
angela97lin
angela97lin approved these changes Jan 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gsheni!

Comment thread .github/workflows/auto_approve_dependency_PRs.yml
@gsheni gsheni merged commit 685694a into main Jan 20, 2022
@gsheni gsheni deleted the update_auto_approve branch January 20, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freddyaboulton freddyaboulton Awaiting requested review from freddyaboulton

1 more reviewer

@angela97lin angela97lin angela97lin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gsheni gsheni

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gsheni @angela97lin