Update pmdarima version to fix nightlies
#3268
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3268 +/- ##
=====================================
Coverage 99.8% 99.8%
=====================================
Files 326 326
Lines 31497 31497
=====================================
Hits 31406 31406
Misses 91 91 Continue to review full report at Codecov.
|
angela97lin
changed the title
pmdarima version to fix nightlies
| @@ -1,8 +1,11 @@ | |||
| name: Nightly unit tests, linux | |||
|
|
|||
| on: | |||
| schedule: | |||
| - cron: '0 7 * * *' | |||
| pull_request: | |||
There was a problem hiding this comment.
Will revert this file before merging
Makefile
Outdated
| @@ -84,7 +84,7 @@ git-test-integration: | |||
| .PHONY: installdeps | |||
| installdeps: | |||
| pip install --upgrade pip -q | |||
| pip install -e . -q | |||
| pip install -e . -v | |||
There was a problem hiding this comment.
Will also revert this file
angela97lin
requested review from
freddyaboulton,
bchen1116,
ParthivNaresh,
chukarsten,
dsherry and
jeremyliweishih
| @@ -13,7 +13,7 @@ | |||
| name='evalml', | |||
| version='0.42.0', | |||
| author='Alteryx, Inc.', | |||
| author_email='support@featurelabs.com', | |||
|
@freddyaboulton Never mind, looks like just using a newer version of |
| @@ -10,7 +10,7 @@ graphviz>=0.13;platform_system!='Windows' | |||
| seaborn>=0.11.1 | |||
| category_encoders>=2.2.2 | |||
| imbalanced-learn>=0.8.0 | |||
| pmdarima==1.8.0 | |||
| pmdarima>=1.8.1 | |||
There was a problem hiding this comment.
Does 1.8.1 actually work in 3.9? Let’s merge this in to fix the nightlies but wondering if we need to use >=1.8.4
There was a problem hiding this comment.
@freddyaboulton I think since I just set a lower bound, it ended up installing 1.8.4 anyways (https://github.com/alteryx/evalml/runs/4902413563?check_suite_focus=true); I can check 1.8.1 by hardcoding and see what happens? 👀
There was a problem hiding this comment.
Looks good in 3.9 even with 1.8.1!! #3271
Pull Request Description
(replace this text with your description)
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.