Skip to content

Upgrade to WW version 0.12.0 - #3290

Merged
jeremyliweishih merged 13 commits into
mainfrom
js_fix_ww_upgrade
Jan 28, 2022
Merged

jeremyliweishih merged 13 commits into
mainfrom
js_fix_ww_upgrade

Conversation

@jeremyliweishih

@jeremyliweishih jeremyliweishih commented Jan 28, 2022 •

Copy link
Copy Markdown
Collaborator

Fixes docstring failing for WW version 0.12.0 brought up in #3289. Sneaking in a vowpalwabbit cap and some other dependency changes to unblock CI.

To recap:

  1. We first upgraded woodwork and fixed the docstring failure
  2. However, shap tests were breaking on min-deps tests which could be related to this and this. So we bumped up the SHAP version.
  3. vowpalwabbit also released during this period of time and broke our windows tests. To fix this we capped VPW for now
  4. Lastly added the lastest dask release to latest_dependency_versions.txt as dask released as well.
  5. However, VPW wheel got picked up on PyPI so reverting the cap.

@codecov

codecov Bot commented Jan 28, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #3290 (699d7a5) into main (f73fa0f) will increase coverage by 26.9%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #3290      +/-   ##
========================================
+ Coverage   72.9%   99.8%   +26.9%     
========================================
  Files        322     322              
  Lines      31600   31600              
========================================
+ Hits       23031   31510    +8479     
+ Misses      8569      90    -8479     
Impacted Files Coverage Δ
evalml/data_checks/outliers_data_check.py 100.0% <ø> (+4.0%) ⬆️
...valml/tests/pipeline_tests/test_component_graph.py 99.9% <0.0%> (+0.2%) ⬆️
evalml/tests/pipeline_tests/test_pipelines.py 99.8% <0.0%> (+0.2%) ⬆️
evalml/tests/component_tests/test_utils.py 95.7% <0.0%> (+1.1%) ⬆️
evalml/utils/gen_utils.py 98.8% <0.0%> (+1.3%) ⬆️
evalml/tests/utils_tests/test_logger.py 100.0% <0.0%> (+1.5%) ⬆️
evalml/tests/component_tests/test_components.py 99.3% <0.0%> (+1.5%) ⬆️
evalml/tests/pipeline_tests/test_pipeline_utils.py 99.7% <0.0%> (+1.6%) ⬆️
evalml/objectives/standard_metrics.py 100.0% <0.0%> (+1.7%) ⬆️
...tors/regressors/exponential_smoothing_regressor.py 100.0% <0.0%> (+2.2%) ⬆️
... and 157 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f73fa0f...699d7a5. Read the comment docs.

@jeremyliweishih
jeremyliweishih requested review from a team and tamargrey and removed request for a team and tamargrey January 28, 2022 16:13

@tamargrey tamargrey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jeremyliweishih jeremyliweishih changed the title Allow WW version 0.12.0 Upgrade to WW version 0.12.0 Jan 28, 2022

@freddyaboulton freddyaboulton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍 Thanks @jeremyliweishih

@jeremyliweishih
jeremyliweishih merged commit e2bca54 into main Jan 28, 2022
@chukarsten chukarsten mentioned this pull request Feb 4, 2022
@freddyaboulton
freddyaboulton deleted the js_fix_ww_upgrade branch May 13, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants